AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080314105537.42219c15@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<kumarv@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E08DF3989@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 14 Mar 2008 10:55:49 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Kumar Vakacharla (HCL)" <kumarv@onstor.com>
Subject: Re: Review Request :  TED00021741 and TED00022673
Message-ID: <20080314105549.0a5d727c@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E08DF3989@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E08D2A078@onstor-exch02.onstor.net>
	<20080311155245.24cc6fab@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08D2A105@onstor-exch02.onstor.net>
	<20080311164220.32f4c2ff@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08D2A55A@onstor-exch02.onstor.net>
	<20080312111028.32589952@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08DF3989@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 14 Mar 2008 09:24:25 -0700 "Kumar Vakacharla (HCL)"
<kumarv@onstor.com> wrote:

> Andy,
> 
>  
> 
>  
> 
>       I have done with my changes and please review them.
> 
>  
> 
> Defect  TED00021741 [Cougar] user with CLUSTER,SECURITY in clustesr
> priveleges cannot find or view elog messages
> 
>  
> 
>  
> 
> >>Go ahead and fix that bug then.  The 'weekly' means that it will be
> 
> >>rotated weekly or by size, whichever comes first.  I think that's
> fine.
> 
>  
> 
> It seems its not working as you expected. The rotation not happens if
> it exceeds the size specified. From the man page of logrotate...
> 
>  
> 
> CONFIGURATION FILE
>        logrotate  reads  everything  about the log files it should be
> handling
>        from the series of configuration files specified on the
> command line.
>        Each configuration file can set global options (local
> definitions over-
>        ride global ones, and later  definitions  override  earlier
> ones)  and
>        specify some logfiles to rotate. A simple configuration file
> looks like
>        this:
> 
>  
> 
> The weekly directive which comes after the size directive in our file
> (logrotate.d/onstor) is overwriting the rotation mechanism to
> weekly.  
> 
> I have tried by interchanging their positions and it is working based
> on size. 
> 
>  
> 
> Files Modified: 
> 
>  
> 
> *         linux/rootfs/Makefile
> 
> *         linux/rootfs/etc/cron.daily/sysklogd
> 
> *         linux/rootfs/etc/cron.weekly/sysklogd
> 
> *         linux/rootfs/etc/logrotate.d/exim4-base
> 
> *         linux/rootfs/etc/logrotate.d/onstor#2 
> 
>  
> 
>  
> 
> Defect  TED00022673 /var full on g5r204. log files are taking all the
> space.
> 
>  
> 
> I have analyzed this defect and found that elog messages are getting
> logged into the following files in addition to the
> /var/log/onstor/messages.
> 
>  
> 
>       "/var/log/syslog" -- all elogs,
> 
>       "/var/log/messages" -- with priority warn,,info and notice 
> 
>       "/var/log/kern.log" -- messages from fp and txrx.
> 
>  
> 
> Hence they are growing bigger and bigger and occupies space. 
> 
> I have corrected syslog.conf so that these elog messages (facilities
> local0 to local7) will not go into these logs. 
> 
>  
> 
> Files Modified for this defect:
> 
>  
> 
> *        linux/rootfs/etc/syslog.conf#1 add
> 
> *        nfx-tree/code/ssc-elog/syslog.conf.linux#1 edit
> 
> *         linux/rootfs/Makefile
> 
>  
> 
>  
> 
>  
> 
>  
> 
> I have captured all these changes as a single change list 28319.
> 
>  
> 
>  
> 
> P4CLIENT=kumarv-DEV 
> 
> Location: /homes/kumarv/work/dev  
> 
> Change list # : 28319
> 
>  
> 
>  
> 
> kumarv@compile2>p4 describe 28319
> 
> Change 28319 by perforce@kumarv-DEV on 2008/03/12 17:51:32 *pending*
> 
>  
> 
>         Defect TED00021741 [Cougar]
> 
>            user with CLUSTER,SECURITY in clustesr priveleges cannot
> find or view elog
> 
>            messages.
> 
>  
> 
>            Corrected some issues with the elog messages rotation
> process so that
> 
>            logrotate will handle it instead of default savelog
> mechanism.
> 
>  
> 
>            Defect  TED00022673
> 
>                /var full on g5r204. log files are taking all the
> space.
> 
>  
> 
>               Modified syslog.conf so that elog messages will not go
> into the
> 
>               system logs(/var.log/syslog, /var/log/messages,
> /var/log/kern.log).
> 
>  
> 
> Affected files ...
> 
>  
> 
> ... //depot/dev/linux/rootfs/Makefile#23 edit
> 
> ... //depot/dev/linux/rootfs/etc/cron.daily/sysklogd#1 add
> 
> ... //depot/dev/linux/rootfs/etc/cron.weekly/sysklogd#1 add
> 
> ... //depot/dev/linux/rootfs/etc/logrotate.d/exim4-base#1 add
> 
> ... //depot/dev/linux/rootfs/etc/logrotate.d/onstor#2 edit
> 
> ... //depot/dev/linux/rootfs/etc/syslog.conf#1 add
> 
> ... //depot/dev/nfx-tree/code/ssc-elog/syslog.conf.linux#1 edit
> 
> kumarv@compile2>
> 
>  
> 
>  
> 
> PS:  I have sent Makefile changes to Larry as I added new files under
> linux/rootfs/etc. I am still waiting for his reply. 

Just an FYI.

In general, send to just one reviewer.  That reviewer can farm out
pieces if they are over his/her head or just for efficiency reasons.
Some times it is appropriate to send to multiple people, in those
cases, send the whole thing to all reviewers.

This stuff should probably be put in a wiki somewhere.  Hmm.

My review is coming soon.

Cheers,

a

