AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080317141116.1a54d867@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<paul.hammer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 17 Mar 2008 14:12:01 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Paul Hammer <paul.hammer@onstor.com>
Subject: additional item for review list
Message-ID: <20080317141201.120331d8@ripper.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi Paul,

This is from my notes from your tech-talk last Thursday.  I don't have
a copy of the slides, but there was one slide with a number of
code-review-checkin guidelines or conventions.

There is an additional item that needs to be added to the things under
code-review-checkin list, and that is checkin comment. The checkin
comment also must be reviewed at the time of code review.

Currently when someone sends me a review request, I ask them to put it
into a separate changelist, where I can review both the changes and the
checkin comment.

Cheers,

a
