AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080318153317.5118b1f3@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<kumarv@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E08F021BD@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 18 Mar 2008 15:33:32 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Kumar Vakacharla (HCL)" <kumarv@onstor.com>
Subject: Re: Review Request :  TED00021741 and TED00022673
Message-ID: <20080318153332.327fdfc6@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E08F021BD@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E08D2A078@onstor-exch02.onstor.net>
	<20080311155245.24cc6fab@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08D2A105@onstor-exch02.onstor.net>
	<20080311164220.32f4c2ff@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08D2A55A@onstor-exch02.onstor.net>
	<20080312111028.32589952@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08DF3989@onstor-exch02.onstor.net>
	<20080314105937.3f4b1029@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08DF3AF3@onstor-exch02.onstor.net>
	<20080314142337.39386478@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E08F021BD@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

So, fix that one trailing whitespace problem and then go ahead and
check it in.



linux/rootfs/Makefile

     looks good

linux/rootfs/etc/cron.daily/sysklogd


     massive trailing whitespace on lines 30 and 31

     otherwise looks good


linux/rootfs/etc/cron.weekly/sysklogd


     >>add linux/rootfs/etc/cron.weekly/sysklogd

     looks good


linux/rootfs/etc/logrotate.d/onstor


     looks good

nfx-tree/code/ssc-elog/syslog.conf.linux


     looks good



On Mon, 17 Mar 2008 17:38:42 -0700 "Kumar Vakacharla (HCL)"
<kumarv@onstor.com> wrote:

> Andy, 
> 
> 	Can you please let me know whether I can check-in these
> changes?
> 
> 
> Thanks,
> Kumar.
> 
> -----Original Message-----
> From: Kumar Vakacharla (HCL) 
> Sent: Friday, March 14, 2008 7:13 PM
> To: Andy Sharp
> Subject: RE: Review Request : TED00021741 and TED00022673
> 
> Andy, 
> 
> 	Please verify the rework.
> 
> 	This rework excludes exim4-base and /etc/syslog.conf changes
> as Larry said he is going to solve the syslog.conf issue as we
> discussed.
> 
> Changes Incorporated: 
> 
> >>add linux/rootfs/etc/cron.weekly/sysklogd
> line 26, trailing whitespace
> Kumar> Done. 
> 
> 
> >>linux/rootfs/etc/logrotate.d/onstor 
> Kumar> Added back the weekly directive.
> 
> 
> >>nfx-tree/code/ssc-elog/syslog.conf.linux
> Kumar> Removed the unwanted file entries as you suggested. uucp.*,
> news.* and /dev/xconsole entry (at the end)
> 
> >>linux/rootfs/Makefile
> Kumar> Removed the addition of new files etc/logrotate.d/exim4-base
> Kumar> and
> etc/syslog.conf. 
> 
> P4CLIENT=kumarv-DEV
> Location: /homes/kumarv/work/dev
> Change list #: 28319.
> 
> kumarv@compile2>p4 describe 28319
> Change 28319 by perforce@kumarv-DEV on 2008/03/12 17:51:32 *pending*
> 
>   Defect TED00021741 [Cougar]
>      user with CLUSTER,SECURITY in clustesr priveleges cannot find or
> view elog
>      messages.
> 
>      Corrected some issues with the elog messages rotation process so
> that
>      logrotate will handle it instead of default savelog mechanism.
> 
>      Defect  TED00022673
>          /var full on g5r204. log files are taking all the space.
> 
>         Modified syslog.conf so that elog messages will not go to the
>         system logs(/var.log/syslog, /var/log/messages,
> /var/log/kern.log).
> 
> Affected files ...
> 
> ... //depot/dev/linux/rootfs/Makefile#24 edit
> ... //depot/dev/linux/rootfs/etc/cron.daily/sysklogd#1 add
> ... //depot/dev/linux/rootfs/etc/cron.weekly/sysklogd#1 add
> ... //depot/dev/linux/rootfs/etc/logrotate.d/onstor#2 edit
> ... //depot/dev/nfx-tree/code/ssc-elog/syslog.conf.linux#1 edit
> kumarv@compile2>
> 
> Thanks,
> Kumar.
