AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080319193303.328dff07@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E08F02D47@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 19 Mar 2008 19:33:26 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20080319193326.0e88b692@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E08F02D47@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E08F02D47@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

In all the excitement to day I forgot to restart my email client.  Doh.

nfx-tree/code/ssc-cluster/cluster-api.c

     looks good

nfx-tree/code/ssc-cluster/cluster-api.h

     looks good

nfx-tree/code/ssc-nfxsh/menu.c

     enable/disable TerminaEcho
      - we have a function that reads a password - should we just
      add this if (INTERACTIVE) test to that and get rid of these
      functions?
      - you probably want to make the style of this code consistent:
      spacing around return statement, parens around return value or
      not, remove space(s) between function name and '(', etc. i prefer
      to no have parens around return value since it's not a function,
      but sometimes it increases readability if it's a complicated
      value.  i realize it was probably all cut and pasted....

nfx-tree/code/ssc-nfxsh/nfxsh.h

     fine by me.  just out of curiosity, why don't you want them
     inline anymore?  it's not really obvious why they were inlined
     in the first place as this isn't time critical code or anything.



On Wed, 19 Mar 2008 11:57:00 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Change 28433 by maximk@maximk-13 on 2008/03/19 11:51:33 *pending*
> 
>         Move the unnecessary inline functions into .c files.
>            Reviewed by andys.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-api.c#12 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-api.h#3 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/menu.c#11 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/nfxsh.h#9 edit
> 
