AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<sripal.surendiran@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	47E4BCED.90808@onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Sat, 22 Mar 2008 01:45:02 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Sripal <sripal.surendiran@onstor.com>
Subject: Re: PERFORCE change 28467 for review
Message-ID: <20080322014502.7a1db093@ripper.onstor.net>
In-Reply-To: <47E4BCED.90808@onstor.com>
References: <WEBMAILnTQkaMGD7wK500001330@mail.onstor.com>
	<20080321165641.155eaa50@ripper.onstor.net>
	<47E4BCED.90808@onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

linux/rootfs/etc/dhcp3/dhclient.conf

     >>add linux/rootfs/etc/dhcp3/dhclient.conf

     line 55 s/them/time/

     line 58, spacing



On Sat, 22 Mar 2008 13:31:49 +0530 Sripal
<sripal.surendiran@onstor.com> wrote:

> Andy,
> 
> Just added the file without doing p4 add. Request you review the file
> 
> change id : 28486
> 
> Regards,
> Sripal.
> 
> Andrew Sharp wrote:
> > On 21 Mar 2008 10:40:02 -0700 QA-HCL <ken.renshaw@onstor.com> wrote:
> >
> >   
> >> Change 28467 by perforce@sripal-rcg_fti on 2008/03/21 10:36:44
> >>
> >> 	Initial configuration code for Cougar (Initial Version). 
> >> 	Contains changes to initial configuration API, CLI, NCM and
> >> rootfs scripts. Reviewed by andys.
> >>
> >> Affected files ...
> >>
> >> ... //depot/cg_fti/linux/rootfs/Makefile#2 edit
> >> ... //depot/cg_fti/linux/rootfs/etc/init.d/onstor#2 edit
> >> ... //depot/cg_fti/linux/rootfs/etc/init.d/onstor-config#2 edit
> >> ... //depot/cg_fti/linux/rootfs/etc/onstor/initial-config#2 edit
> >> ... //depot/cg_fti/linux/rootfs/sbin/dhclient-script#1 add
> >> ... //depot/cg_fti/nfx-tree/Makefile#2 edit
> >> ... //depot/cg_fti/nfx-tree/code/sm-sct/taskmgr.c#2 edit
> >> ... //depot/cg_fti/nfx-tree/code/ssc-initial-config/Makefile#2 edit
> >> ... //depot/cg_fti/nfx-tree/code/ssc-initial-config/initial-config-linux.c#1
> >> add ... //depot/cg_fti/nfx-tree/code/ssc-initial-config/initial-config-openbsd.c#1
> >> add ... //depot/cg_fti/nfx-tree/code/ssc-initial-config/initial-config.c#2
> >> edit ... //depot/cg_fti/nfx-tree/code/ssc-initial-config/initial-config.h#2
> >> edit ... //depot/cg_fti/nfx-tree/code/ssc-initial-config/linux.h#1
> >> add ... //depot/cg_fti/nfx-tree/code/ssc-initial-config/migrate.sh#1
> >> add ... //depot/cg_fti/nfx-tree/code/ssc-initial-config/minlabel.c#1
> >> add ... //depot/cg_fti/nfx-tree/code/ssc-initial-config/minlabel.h#1
> >> add ... //depot/cg_fti/nfx-tree/code/ssc-initial-config/openbsd.h#1
> >> add ... //depot/cg_fti/nfx-tree/code/ssc-nfxsh/Makefile#2 edit
> >> ... //depot/cg_fti/nfx-tree/code/ssc-nfxsh/cmd_flash.c#2 edit
> >> ... //depot/cg_fti/nfx-tree/code/ssc-nfxsh/vtysh-linux.c#2 delete
> >> ... //depot/cg_fti/nfx-tree/code/ssc-nfxsh/vtysh-openbsd.c#2 delete
> >> ... //depot/cg_fti/nfx-tree/code/ssc-nfxsh/vtysh_initial.c#1 add
> >> ... //depot/cg_fti/nfx-tree/code/ssc-pm/rc.onstor#2 edit
> >> ... //depot/cg_fti/openbsd/src/etc/Makefile#2 edit
> >> ... //depot/cg_fti/openbsd/src/etc/rc#2 edit
> >> ... //depot/cg_fti/openbsd/src/etc/rc.initial#2 edit
> >> ... //depot/cg_fti/openbsd/src/usr.sbin/dhcp/dhclient/scripts/dhclient-script#2
> >> edit
> >>     
> >                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> > This file was not in the last change list that I reviewed. How'd it
> > get back in?  It has no changes.  Please update your perforce
> > client config to add
> >
> > SubmitOptions:  revertunchanged
> >
> > Not to mention that it looks like you forgot 
> > linux/rootfs/etc/dhcp3/dhclient.conf
> > which I will need to review.
> >
> >   
> 
> 
