AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080324154544.39e57242@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E090EA404@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 24 Mar 2008 15:46:24 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: please review 28499
Message-ID: <20080324154624.35dca754@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E090EA404@onstor-exch02.onstor.net>
References: <20080324152029.70c325c3@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E090EA404@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 24 Mar 2008 15:29:28 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Did you test that it still works on bobcat? There must be some reason
> that it was using -S option instead of -I.

I did test, but not that part exactly.  There is no -S option documented
in the ping usage or the man page for the command.  I tried it by hand
and it didn't seem to care whether I used -S or -I when I fed it an IP
address.  Neither one worked ~:^)  I assume because I have no vsvr or
fp IP address set up on my bobcat.

# ping -S 192.167.1.1 onstor.com
ping: bind: Can't assign requested address
# ping -I 192.167.1.1 onstor.com 
ping: bind: Can't assign requested address

On cougar which is properly set up:

coolcat:~#  ping -I 192.167.1.1 onstor.com 
PING onstor.com (64.62.215.40) from 192.167.1.1 : 56(84) bytes of data.
64 bytes from onstor.com (64.62.215.40): icmp_seq=2 ttl=55 time=25.5 ms
64 bytes from onstor.com (64.62.215.40): icmp_seq=3 ttl=55 time=20.8 ms


> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Monday, March 24, 2008 3:20 PM
> >To: Maxim Kozlovsky
> >Subject: please review 28499
> >
> >Change 28499 by andys@ripper on 2008/03/24 15:12:43 *pending*
> >
> >        Fix TED00022924 - system ping -c N does not work
> >
> >        This was marked for cougar but it looked to me like it
> >        wouldn't work too well on bobcat either.  The count option
> >        wasn't being handled right.
> >
> >        Took the opportunity to clean up all the code for system
> > ping.
> >
> >        reviewed by
> >
> >Affected files ...
> >
> >... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#43 edit
> >... //depot/dev/nfx-tree/code/ssc-nfxsh/linux.h#11 edit
> >... //depot/dev/nfx-tree/code/ssc-nfxsh/openbsd.h#11 edit
> 
