AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080326162912.3b2ef4a2@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ian.brown@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	33640	98FF098C-EC04-48EA-8006-723801D65B96@onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 26 Mar 2008 16:30:08 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Ian Brown <ian.brown@onstor.com>
Subject: Re: please review 28512
Message-ID: <20080326163008.548e2def@ripper.onstor.net>
In-Reply-To: <98FF098C-EC04-48EA-8006-723801D65B96@onstor.com>
References: <20080326101159.692d0705@ripper.onstor.net>
 <98FF098C-EC04-48EA-8006-723801D65B96@onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 26 Mar 2008 13:01:41 -0700 Ian Brown <ian.brown@onstor.com>
wrote:

> emrscron :
> 	- line 444 & 450 -- if HOME and MAILTO need to be added then
> you will get two copies of $TMPFILE in /tmp/cronfoo.  probably not
> good.

I'm looking at the code and I think it will overwrite /tmp/cronfoo each
time with a fresh copy, so it should be fine.

> 	- line 471 --  don't add back kill all -- cause ermscron
> kills itself -- I've tested it.  that's why I removed it.

It kills itself with or without the killall.  I added a little logic to
make the killall work.

>          - line 1402 -- add brackets to 'logrotate', i.e.  
> 'logrotat[e]' so that the grep doesn't find itself in the 'ps ax'

dang, i just couldn't figure out why you were doing that.

fixed.



Added a couple new files to the changelist, as they got caught up in
things as I went around testing and fixing.  Here is the re-listing:

Change 28512 by andys@ripper on 2008/03/25 16:06:29 *pending*

        Fix TED00022295 - Cougar - crontab entries missing
        
        I can't find anywhere that is in charge of adding the HOME and
        MAILTO lines to the crontab, so I'm putting code in emrscron
        to preserve them, and add them if they don't exist.
        
        Add back killall for Linux, otherwise emrscron kills itself.
        
        Fixed a couple of spots that were checking for newsyslog on Linux.
        
        Seed the root crontab when we build the rootfs.
        
        Add -q option to modify-cron so it can be quieted down.
        
        Fix the output of /etc/init.d/onstor here and there especially
        during shutdown.
        
        reviewed by

Affected files ...

... //depot/dev/linux/rootfs/etc/init.d/onstor#4 edit
... //depot/dev/linux/rootfs/etc/init.d/rcS#5 edit
... //depot/dev/nfx-tree/code/ssc-modify-cron/modify-cron.c#3 edit
... //depot/dev/nfx-tree/code/ssc-support/emrscron#18 edit



> On Mar 26, 2008, at 10:11 AM, Andrew Sharp wrote:
> 
> Change 28512 by andys@ripper on 2008/03/25 16:06:29 *pending*
> 
>         Fix TED00022295 - Cougar - crontab entries missing
> 
>         I can't find anywhere that is in charge of adding the HOME and
>         MAILTO entries for the crontab, so I'm putting code in
> emrscron to preserve them, and add them if they don't exist.
> 
>         Add back killall for Linux, otherwise emrscron kills itself.
> 
>         Fixed a couple of spots that were checking for newsyslog on  
> Linux.
> 
>         Seed the root crontab when we build the rootfs.
> 
>         reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/linux/rootfs/etc/init.d/rcS#5 edit
> ... //depot/dev/nfx-tree/code/ssc-support/emrscron#18 edit
> 
> 
