AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080327123701.71431e1a@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C94FE@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 27 Mar 2008 12:37:51 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review 28529
Message-ID: <20080327123751.1298b86d@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C94FE@onstor-exch02.onstor.net>
References: <20080326205439.5c1f34d3@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C94FE@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 27 Mar 2008 11:49:42 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> linux/rootfs/etc/mdrive_fstab
> 
>      looks good
> 
> nfx-tree/Tools/flash_install.sh
> 
>      Line 521: Looks like $1 is ${disk}${part} this would result in
>      a syntax error from expr.

Hmm, coulda sworn that worked fine when I tested it.  Oh well, fixed.

> nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c
> 
>      Line 276: Subtracting 18 from integers 1, 3, and 4? Don't you
>      want to add 30 as you intended in flash_install.sh? If not what
>      am I missing?

You are missing that it's a char. '1' == 49 decimal; 49 - 18 == 31
in shell, '1' and 1 are the same ~:^)

> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, March 26, 2008 8:55 PM
> To: Larry Scheer
> Subject: please review 28529
> 
> Change 28529 by andys@ripper on 2008/03/26 19:09:45 *pending*
> 
>         TED00022813 - EXT3-fs warning: maximal mount count reached
>         
>         Add fsck pass #1 to all mounted CF file systems: e2fsck will
>         serialize them as they are all on the same "disk."  e2fsck
>         will not check the filesystem if it is marked clean unless it
>         surpasses the maximum mount count, which will hopefully be
> rare on production systems.  The max mount count will be left at the
>         default 31 for the moment.  Turn off the maximum time setting
>         in flash_install and _system copy init_.
>         
>         reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/linux/rootfs/etc/mdrive_fstab#1 edit
> ... //depot/dev/nfx-tree/Tools/flash_install.sh#10 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash-linux.c#15 edit
> 
