AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080327131940.3710b9dd@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E03B1C141@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 27 Mar 2008 13:21:06 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review
Message-ID: <20080327132106.2234d34d@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E03B1C141@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E03B1C141@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

include the cl# in the subject so my retarded email client doesn't put
all review requests into the same thread making them "disappear" as it
were.  thanks for helping my retarded email client.


nfx-tree/code/sm-chassis/chassisd-cg.c

     you might want to mention in the checkin comments that the wrong
     value was being written in the case of a system fault anyway. or
     not.

nfx-tree/code/sm-chassis/cm-api-cg.h

     looks good





On Thu, 27 Mar 2008 13:03:01 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> Change: 28537
> 
> Client: rendellf-test
> User:   rendellf
> 
> Description:
>     TED22671: Set the GPP register crash enable bit in the event of a
> TXRX/FP
>     crash so that the Front Panel System LED is set as expected.  The
> boot/up/
>     crash bits in the GPP register are mutually exclusive so the other
> bits
>     must be cleared when setting any one of them.
> 
> Files:
>     //depot/dev/nfx-tree/code/sm-chassis/chassisd-cg.c  # edit
>     //depot/dev/nfx-tree/code/sm-chassis/cm-api-cg.h    # edit
