AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C94FD@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 27 Mar 2008 14:22:02 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Please review change 28526 -dmalloc package
Message-ID: <20080327142202.000fdec0@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C94FD@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C94F7@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C94FD@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

linux/Pkgs/binary/Deb/libdmalloc-dev-mipsel-cross_5.5.1-1_all.deb

     looks good

linux/Pkgs/binary/Deb/libdmalloc-dev_5.5.1-1_mipsel.deb

     looks good

linux/Pkgs/binary/Deb/libdmalloc5-mipsel-cross_5.5.1-1_all.deb

     looks good

linux/Pkgs/binary/Deb/libdmalloc5_5.5.1-1_mipsel.deb

     looks good

linux/Pkgs/binary/Rpm/libdmalloc-dev-mipsel-cross-5.5.1-2.noarch.rpm

     looks good

linux/Pkgs/binary/Rpm/libdmalloc5-mipsel-cross-5.5.1-2.noarch.rpm

     looks good

linux/Pkgs/source/dmalloc/Makefile

     >>add linux/Pkgs/source/dmalloc/Makefile

     	please fix trailing whitespace.

     	line 31, i determined that this doesn't work.  see the
     	exim4 makefile for what i did instead, as i don't remember
     	anymore.  basically, make executes the $(error regardless
     	of shell if statements.

     	line 43, you shouldn't need the '-1', i should think?
     	maybe i'm wrong about that.

     	line 64, move the cd $(PKG_BASE) out line I did in
     	exim4/Makefile, so you don't have to keep repeating it.

     	line 65, it's just easier and seems to work better if
     	you say awk '{print $$2}'.  no -F needed.

     	line 72, make the comment a bit more meaningful.  anyway,
     	i think you meant something more like 'onstor fixes for
     	recursive code use.'

     	Did you say this doesn't cross-build?  If it has to
     	be built on a filer, add comments to that effect.
     	Regardless of that, add comment(s) to list any build
     	dependencies that are "unusual" for this package, if any.

linux/Pkgs/source/dmalloc/debianrules.patch

     >>add linux/Pkgs/source/dmalloc/debianrules.patch

     	line 37, duh, trailing whitespace

linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.diff.gz

     >>add linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.diff.gz

linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.dsc

     >>add linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.dsc

linux/Pkgs/source/dmalloc/dmalloc_5.5.1.orig.tar.gz

     >>add linux/Pkgs/source/dmalloc/dmalloc_5.5.1.orig.tar.gz

linux/Pkgs/source/dmalloc/onstor-src.dpatch

     >>add linux/Pkgs/source/dmalloc/onstor-src.dpatch



On Wed, 26 Mar 2008 18:55:39 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Ok this  change is ready to review. I added :
> 
> ... //depot/dev/linux/Pkgs/source/dmalloc/debianrules.patch#1 add
> 
> To the change list.
> 
> _____________________________________________
> From: Larry Scheer 
> Sent: Wednesday, March 26, 2008 4:22 PM
> To: Andy Sharp
> Subject: Please review change 28526 -dmalloc package
> 
> Change 28526 by larrys@larrys on 2008/03/26 16:21:05 *pending*
> 
>         Files to re-build the libdmalloc package with ONStor changes.
> Adds
>         the Makefile, onstor patch file and specific source packages
> for the current release of the Cougar platform. This version of the
>         source do not cross compile so build must be done on a MIPSEL
> system.
> 
>         Updating pre-built debian packages and cross packages in both
> debian and
>         rpm format that have Max's fix for re-entrant code (memset in
> signal
>         handler.)
>         Reviewed by: AndyS
> 
> Affected files ...
> 
> ...
> //depot/dev/linux/Pkgs/binary/Deb/libdmalloc-dev-mipsel-cross_5.5.1-1_al
> l.deb#1 edit
> ...
> //depot/dev/linux/Pkgs/binary/Deb/libdmalloc-dev_5.5.1-1_mipsel.deb#1
> edit
> ...
> //depot/dev/linux/Pkgs/binary/Deb/libdmalloc5-mipsel-cross_5.5.1-1_all.d
> eb#1 edit
> ... //depot/dev/linux/Pkgs/binary/Deb/libdmalloc5_5.5.1-1_mipsel.deb#1
> edit
> ...
> //depot/dev/linux/Pkgs/binary/Rpm/libdmalloc-dev-mipsel-cross-5.5.1-2.no
> arch.rpm#1 edit
> ...
> //depot/dev/linux/Pkgs/binary/Rpm/libdmalloc5-mipsel-cross-5.5.1-2.noarc
> h.rpm#1 edit
> ... //depot/dev/linux/Pkgs/source/dmalloc/Makefile#1 add
> ... //depot/dev/linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.diff.gz#1
> add ... //depot/dev/linux/Pkgs/source/dmalloc/dmalloc_5.5.1-1.dsc#1
> add ... //depot/dev/linux/Pkgs/source/dmalloc/dmalloc_5.5.1.orig.tar.gz#1
> add
> ... //depot/dev/linux/Pkgs/source/dmalloc/onstor-src.dpatch#1 add
