AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080330043135.3b59501a@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<sripal.surendiran@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	47EDF81C.50805@onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Sun, 30 Mar 2008 04:32:33 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Sripal <sripal.surendiran@onstor.com>
Subject: Re: Code review
Message-ID: <20080330043233.01730b94@ripper.onstor.net>
In-Reply-To: <47EDF81C.50805@onstor.com>
References: <47EBCBD2.1080809@onstor.com>
	<47EDF81C.50805@onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Aha, I reviewed it but then thought I would have someone else look at
it too, but then forgot to tell that person.  My bad.

Anyway, I thought about it some more and I think my review is good
enough.  Here it is:


nfx-tree/code/ssc-genlib/genlib-linux.c


     looks ok, but why are these in genlib?  are they cli used only
     functions?  if so, they can go in ssc-nfxsh/cmd_system*.c or
     something like that.  hmm, i'm thinking you used them in
     initial-config as well.


nfx-tree/code/ssc-genlib/genlib-openbsd.c


     line 196, instead of all this snprintf stuff, can you use
     do_system()?


nfx-tree/code/ssc-genlib/genlib.h


     line 136,158, even though someone has been violating this,
     function declarations should be all one line with their type:

     int foo(args);

     as opposed to

     int
     foo(args);

     whereas function definitions should be the opposite.


nfx-tree/code/ssc-initial-config/initial-config.c


     line 282, it seems like this removed routine,
     initconf_modifyTimeZone should work fine for Linux as well as BSD?
     if so, then the other functions can be moved into libnfxsh?


nfx-tree/code/ssc-nfxsh/cmd_system-linux.c


     ok


nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c


     ok


nfx-tree/code/ssc-nfxsh/cmd_system.c


     looks good





On Sat, 29 Mar 2008 13:34:44 +0530 Sripal
<sripal.surendiran@onstor.com> wrote:

> Gentle reminder.....
> 
> -Sripal.
> 
> Sripal wrote:
> > Andy,
> >
> > I have made changes to genlib files as a part of fixing bug 
> > TED00022994 (Timezone entered in FTI does not show up in cli 
> > commands). Request you review the modified files.
> >
> > Change id : 28533
> >
> > Thanks,
> > Sripal.
> >
> 
