AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080402103608.46c393a7@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
FMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	47F3BA97.8060503@onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 2 Apr 2008 10:37:30 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Subject: Fw: Code review 28626
Message-ID: <20080402103730.38f917d6@ripper.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary=MP_s66g8D5+Ze7rG8HfAURGAU5

--MP_s66g8D5+Ze7rG8HfAURGAU5
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi Larry,

Could you review this change?  I've reviewed it once, and I think
everything is OK except I'm still not sure about the removed function
from initial-config.c.  He says it can't be portable, but I thought you
had some thoughts to the opposite.  Something like we could do a
symlink on Linux just like OpenBSD does.  Let me know what you think.

I put a note next to the review comment I'm talking about.



Begin forwarded message:

Date: Wed, 02 Apr 2008 22:25:51 +0530
From: Sripal <sripal.surendiran@onstor.com>
To: Andrew Sharp <andy.sharp@onstor.com>
Subject: Re: Code review


Andy,

Since FTI code is merged to dev branch, I moved my changes to dev
branch.

New change id: 28626

Also see my inline comments below

Thanks,
Sripal.

Andrew Sharp wrote:
> Aha, I reviewed it but then thought I would have someone else look at
> it too, but then forgot to tell that person.  My bad.
>
> Anyway, I thought about it some more and I think my review is good
> enough.  Here it is:
>
>
> nfx-tree/code/ssc-genlib/genlib-linux.c
>
>
>      looks ok, but why are these in genlib?  are they cli used only
>      functions?  if so, they can go in ssc-nfxsh/cmd_system*.c or
>      something like that.  hmm, i'm thinking you used them in
>      initial-config as well.
> Sripal>>You are correct.
>
> nfx-tree/code/ssc-genlib/genlib-openbsd.c
>
>
>      line 196, instead of all this snprintf stuff, can you use
>      do_system()?
> Sripal>>Done
>
> nfx-tree/code/ssc-genlib/genlib.h
>
>
>      line 136,158, even though someone has been violating this,
>      function declarations should be all one line with their type:
>
>      int foo(args);
>
>      as opposed to
>
>      int
>      foo(args);
>
>      whereas function definitions should be the opposite.
> Sripal>>Done
>
> nfx-tree/code/ssc-initial-config/initial-config.c
>

I'm still not convinced the following routing can't be portable, but I
know you've put some quality time in on this issue, so I thought I
would get your feedback on it.

>      line 282, it seems like this removed routine,
>      initconf_modifyTimeZone should work fine for Linux as well as
> BSD? if so, then the other functions can be moved into libnfxsh?
> Sripal>>No. In openbsd, we link /etc/localtime to actual time zone
> Sripal>>file in /usr/share/zoneinfo/. But in Linux, we copy the
> Sripal>>actual time zone file to /etc/localtime. We also enter the
> Sripal>>zone name to /etc/timezone file. This difference has actually
> Sripal>>created bug in FTI.
>
> nfx-tree/code/ssc-nfxsh/cmd_system-linux.c
>
>
>      ok
>
>
> nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c
>
>
>      ok
>
>
> nfx-tree/code/ssc-nfxsh/cmd_system.c
>
>
>      looks good
>
>
>
>
>
> On Sat, 29 Mar 2008 13:34:44 +0530 Sripal
> <sripal.surendiran@onstor.com> wrote:
>
>   
>> Gentle reminder.....
>>
>> -Sripal.
>>
>> Sripal wrote:
>>     
>>> Andy,
>>>
>>> I have made changes to genlib files as a part of fixing bug 
>>> TED00022994 (Timezone entered in FTI does not show up in cli 
>>> commands). Request you review the modified files.
>>>
>>> Change id : 28533
>>>
>>> Thanks,
>>> Sripal.
>>>
>>>       

--MP_s66g8D5+Ze7rG8HfAURGAU5
Content-Type: text/html
Content-Transfer-Encoding: 7bit

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Andy,<br>
<br>
Since FTI code is merged to dev branch, I moved my changes to dev
branch.<br>
<br>
New change id: 28626<br>
<br>
Also see my inline comments below<br>
<br>
Thanks,<br>
Sripal.<br>
<br>
Andrew Sharp wrote:
<blockquote cite="mid:20080330043233.01730b94@ripper.onstor.net"
 type="cite">
  <pre wrap="">Aha, I reviewed it but then thought I would have someone else look at
it too, but then forgot to tell that person.  My bad.

Anyway, I thought about it some more and I think my review is good
enough.  Here it is:


nfx-tree/code/ssc-genlib/genlib-linux.c


     looks ok, but why are these in genlib?  are they cli used only
     functions?  if so, they can go in ssc-nfxsh/cmd_system*.c or
     something like that.  hmm, i'm thinking you used them in
     initial-config as well.
<font color="#cc33cc">Sripal&gt;&gt;You are correct.</font>

nfx-tree/code/ssc-genlib/genlib-openbsd.c


     line 196, instead of all this snprintf stuff, can you use
     do_system()?
<font color="#cc33cc">Sripal&gt;&gt;Done</font>

nfx-tree/code/ssc-genlib/genlib.h


     line 136,158, even though someone has been violating this,
     function declarations should be all one line with their type:

     int foo(args);

     as opposed to

     int
     foo(args);

     whereas function definitions should be the opposite.
<font color="#cc33cc">Sripal&gt;&gt;Done</font>

nfx-tree/code/ssc-initial-config/initial-config.c


     line 282, it seems like this removed routine,
     initconf_modifyTimeZone should work fine for Linux as well as BSD?
     if so, then the other functions can be moved into libnfxsh?
<font color="#cc33cc">Sripal&gt;&gt;No. In openbsd, we link /etc/localtime to actual time zone file in /usr/share/zoneinfo/. But in Linux, we copy the actual time zone file to /etc/localtime. We also enter the zone name to /etc/timezone file. This difference has actually created bug in FTI.</font>

nfx-tree/code/ssc-nfxsh/cmd_system-linux.c


     ok


nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c


     ok


nfx-tree/code/ssc-nfxsh/cmd_system.c


     looks good





On Sat, 29 Mar 2008 13:34:44 +0530 Sripal
<a class="moz-txt-link-rfc2396E" href="mailto:sripal.surendiran@onstor.com">&lt;sripal.surendiran@onstor.com&gt;</a> wrote:

  </pre>
  <blockquote type="cite">
    <pre wrap="">Gentle reminder.....

-Sripal.

Sripal wrote:
    </pre>
    <blockquote type="cite">
      <pre wrap="">Andy,

I have made changes to genlib files as a part of fixing bug 
TED00022994 (Timezone entered in FTI does not show up in cli 
commands). Request you review the modified files.

Change id : 28533

Thanks,
Sripal.

      </pre>
    </blockquote>
  </blockquote>
</blockquote>
</body>
</html>

--MP_s66g8D5+Ze7rG8HfAURGAU5--
