AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080408101458.1796a104@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E042F0147@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 8 Apr 2008 10:16:33 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review 28660 - should be a quickie
Message-ID: <20080408101633.58e11851@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E042F0147@onstor-exch02.onstor.net>
References: <20080407155033.5f07e017@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C9536@onstor-exch02.onstor.net>
	<20080407170343.2763f205@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E042F0147@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 7 Apr 2008 23:41:01 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> If you just remove the Images directory then flash_install won't work
> on a cheetah. You will always be returning 1 from
> sanity_check_soft_dir() on a cheetah. Here is part of what is wrong"
> From a cheetah:
> athena# echo /*bc.bin | wc -c
> echo: No match.
>        0 
> From a bobcat:
> eng216# echo /*bc.bin | wc -c
>       35

Dude, what do you have on your system?  It doesn't match 35 files on my
system, just three files fc_bc.bin, txrx_bc.bin, and fp_bc.bin.

> 
> This test is always true on both bobcat and cheetah
>   if [ `echo /*bc.bin | wc -c` != 3 ] 
> 
> If I go by the comment on line 166 then I presume you want line 165
> to be: if [ `echo /*bc.bin 2>/dev/null | wc -c` = 35 ] ; then

You must have a lot of images on your system!  Perhaps I should change
it to:

if [ `echo /*bc.bin 2>/dev/null | wc -c` != 0 ] ; then

> I took the liberty to redirect standard error to avoid the potential
> of noise displaying on the console.

That's a good point, I will add that.

> It you want to test your change on a cheetah you can use 10.2.17.1
> (athena) or 10.2.18.1 (minerva). Please don't blow away their
> configurations and cluster db.

That sounds like what I need to do.

> If you need a bobcat to test flash_install you can use 10.2.11.4
> (eng216) again please preserve the configuration and cluster database.

I did test on a Bobcat already, it works there.  I installed first with
the old flash_install, then with the new, worked fine.

> Larry
> 
> -----Original Message-----
> From: Andy Sharp
> Sent: Mon 4/7/2008 5:03 PM
> To: Larry Scheer
> Subject: Re: please review 28660 - should be a quickie
>  
> You must have been thinking of your proposal when the phrase "...make
> no sense" came to mind.  The only thing I had to change, if I
> understand your point, was the removal of the Images directory,
> which, hey, I don't know, I was just guessing.  That's why I sent it
> to you for reviewing.
> 
> Fixed.  As long as the only thing that needed fixing was getting rid
> of the Images directory.
> 
> 
> On Mon, 7 Apr 2008 16:24:17 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > Lines 165 through 173 make no sense. On a cheetah ssc-mgmt.bin is
> > located in $1/ssc-mgmt.bin not in Images. There is no ssc-mgmt.bin
> > anywhere for bobcat.
> > 
> > So I think you meant to write:
> > 
> > if [ `echo /*bc.bin | wc -c` = 3] ; then
> >  # if on a bobcat, don't install cheetah distro
> >  if [ $1/ssc-mgmt.bin ] ; then
> >     return 1
> >  fi
> > # must be on a cheetah ?
> > elif [ ! -e $1/ssc-mgmt.bin ] ; then
> >     return 1
> > fi 
> > 
> > -----Original Message-----
> > From: Andy Sharp 
> > Sent: Monday, April 07, 2008 3:51 PM
> > To: Larry Scheer
> > Subject: Re: please review 28660 - should be a quickie
> > 
> > Alright, added some code, but since I don't have a cheetah, I don't
> > know if it's right.  So please re-review.
> > 
> > 
> > On Fri, 4 Apr 2008 19:54:56 -0700 "Larry Scheer"
> > <larry.scheer@onstor.com> wrote:
> > 
> > > nfx-tree/Tools/flash_install.sh
> > > 
> > >      This will prevent a cheetah or bobcat build from being
> > > installed on a cougar.  But it won't stop a cheetah release from
> > > being installed on a bobcat. Which is fine if that was all you
> > > wanted to at this time
> > > 
> > >      If you want to go one step further a cheetah has this file:
> > >      /ssc-mgmt.bin and bobcats do not. You could test for the
> > > existence of ssc-mgmt.bin if you know you are running on a cheetah
> > > or a bobcat.
> > > 
> > > -----Original Message-----
> > > From: Andy Sharp 
> > > Sent: Thursday, April 03, 2008 2:36 PM
> > > To: Larry Scheer
> > > Subject: please review 28660 - should be a quickie
> > > 
> > > A quickie, hopefully:
> > > 
> > > Change 28660 by andys@ripper on 2008/04/03 14:34:48 *pending*
> > > 
> > >         Bolster sanity check that should prevent installing BSD
> > > onto a Linux based system, and vice-versa.
> > >         
> > >         reviewed by
> > > 
> > > Affected files ...
> > > 
> > > ... //depot/dev/nfx-tree/Tools/flash_install.sh#11 edit
> > > 
> 
