AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<sripal.surendiran@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	48073717.9060506@onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 17 Apr 2008 09:06:42 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Sripal <sripal.surendiran@onstor.com>
Subject: Re: /etc/init.d/onstor-config script for review
Message-ID: <20080417090642.26b3de1d@ripper.onstor.net>
In-Reply-To: <48073717.9060506@onstor.com>
References: <48073717.9060506@onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

linux/rootfs/etc/init.d/onstor-config

     line 81, in general, you should not specify /bin/echo unless you
     need behavior from /bin/echo that is not available from bash's
     builtin echo, which is much faster, since it doesn't have to be
     loaded off the CF, linked with shared libraries, etc.  And the
     "" aren't necessary.  Fix those, and you can check it in.



On Thu, 17 Apr 2008 17:10:07 +0530 Sripal
<sripal.surendiran@onstor.com> wrote:

> Andy,
> 
> Please review the script.
> 
> [sripal@linux-compile init.d]#p4 describe 28860
> Change 28860 by sripal@sripal-rdev on 2008/04/17 04:32:32 *pending*
> 
>         Modified the script to blank out correct dhclient lease file.
>         Before this change,  the script was emptying the wrong file.
> Due to this, the filer has taken the interface IP from the lease file
>         even though DHCP server was not available.
> 
>         Removed extra space, while resetting the interface file.
> 
> Affected files ...
> 
> ... //depot/dev/linux/rootfs/etc/init.d/onstor-config#3 edit
> 
> Thanks,
> Sripal.
> 
