AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080422143614.75e630fb@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>,<chris.vandever@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09624AAB@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 22 Apr 2008 14:36:23 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Cc: "Chris Vandever" <chris.vandever@onstor.com>
Subject: Re: please review 28864
Message-ID: <20080422143623.75f682fe@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09624AAB@onstor-exch02.onstor.net>
References: <20080422101202.35679ff7@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E09624AAB@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 22 Apr 2008 12:00:53 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> cluster-vsvr-api.c: line 5958 - description comments need to be
> updated line 5966 - return value comments also need updating

Fixed.  I also updated the error return logic just a smidgeon.

> cluster-vsvr-api.h: ok

> onstor-vsvr-support.dpatch: line 41: hard coded constant being used
> instead of RMC_SET_APP_VERS().  Is this due to #include conflicts or
> complications? You might want to add comments regarding use of this
> value at minimum or use a local #define. 

Fixed.

> debian.patch: line 1309 - I don't follow what this change is about.

We get this noise about there being something broken if there is
anything in /var/log/exim4/paniclog, and I made some changes a while
back to utilize an environment variable that exists to quiet that down,
but it didn't work.  I suppose I thought that the variable only needed
to be non-null, but apparently you still get the message if it, acting
as a regex to grep, doesn't match every line in the log file.  So I
changed it from "SHADDAP" to ".*".  Seems to work better now.


> -----Original Message-----
> From: Andy Sharp 
> Sent: Tuesday, April 22, 2008 10:12 AM
> To: Chris Vandever
> Cc: Rendell Fong
> Subject: please review 28864
> 
> Chris,
> 
> I am sending this to you because I want you to review the changes to
> the cluster api.  You don't have to look at the other files, but
> you're certainly welcome to if you want to ~:^)
> 
> Rendell,
> 
> Same goes for you, except the two patch files for exim4.  Again,
> you're welcome to look at the rest as well.
> 
> Thanks,
> 
> a
> 
> 
> 
> Change 28864 by andys@ripper on 2008/04/17 12:57:47 *pending*
> 
> 	TED00023344 - autosupport from secondary cluster node not
> working
> 	
> 	Properly obtain the mgmt vsvr id from the cluster API and
> 	query the DNS with it.
> 	
> 	Add a method to the cluster API to return the management vsvr
> id.
> 	
> 	Fix the change that was supposed to shut up the paniclog noise
> 	by putting a regex into /etc/default/exim4 that matches
> anything.
> 	
> 	reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/linux/Pkgs/binary/Deb/exim4-base_4.63-17_mipsel.deb#5
> edit
> ... //depot/dev/linux/Pkgs/binary/Deb/exim4-config_4.63-17_all.deb#2
> edit
> ...
> //depot/dev/linux/Pkgs/binary/Deb/exim4-daemon-custom_4.63-17_mipsel.deb
> #6 edit
> ... //depot/dev/linux/Pkgs/source/exim4/debian.patch#6 edit
> ... //depot/dev/linux/Pkgs/source/exim4/onstor-vsvr-support.dpatch#2
> edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-vsvr-api.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-vsvr-api.h#4 edit
> 
