AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080424102626.72b12bd8@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<chris.vandever@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E03E9A7E2@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 24 Apr 2008 10:27:06 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Chris Vandever" <chris.vandever@onstor.com>
Subject: Re: please review 28864
Message-ID: <20080424102706.684b451c@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E03E9A7E2@onstor-exch02.onstor.net>
References: <20080422151457.7b902833@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E03E9A7E2@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 22 Apr 2008 16:15:34 -0700 "Chris Vandever"
<chris.vandever@onstor.com> wrote:

> Comments inline...
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Tuesday, April 22, 2008 3:15 PM
> To: Chris Vandever
> Subject: Re: please review 28864
> 
> On Tue, 22 Apr 2008 15:05:21 -0700 "Chris Vandever"
> <chris.vandever@onstor.com> wrote:
> 
> > Well, that was fun.  My p4v refused to show me any files beyond
> > cluster-vintf-api.h for some obscure reason.  Thankfully, killing it
> > and restarting a new one did the trick, but it's certainly
> > frustrating when the tools don't frickin' work!
> 
> Use the script, Luke.  It almost never doesn't work ~:^)
>  
> > code/ssc-cluster/cluster-vsvr-api.c:
> > *	@5973 would you rename this cluster_getVsMgmtId() for
> > consistency?  Thanks.
> 
> Consistency with which?  It was that originally, but I could never
> find it because I was always searching for getMgmtVsId "get management
> vserver ID" which is what it does.  So it's consistent with what it
> does ~:^)  "get vserver management ID" doesn't seem to make sense.
> So, my question is, do I have to?
> 
> CV>  Consistency with cluster_getVsMgmtName(), the function directly
> above it.  You can rename cluster_getVsMgmtName() to
> cluster_getMgmtVsName() if you prefer...

OK, I changed both to the correct name.  Notice the 6000 new files
added to this changelist.  Little Timmay would just love that.

> > *	@5979 cluster_getFilerMgmtVsvr() requires 2 + N clusDb
> > accesses. Instead you can just call cluster_getVsMgmtName(), pass
> > the name to cluster_makeVsvrNameKey(), and then read the record
> > data via cluster_getRecordDataByKey().  The record data is the
> > vsId.  This would take a single clusDb lookup.
> 
> But, but, then I would have to write the code myself!  And I would
> have to learn 3 functions when I didn't learn any the first time
> because I copied the code from somewhere else?
> 
> CV>  Stop whining.  Do you want to maintain clustering?  :-)  Okay, to
> make it even easier, just call cluster_getVsMgmtName() followed by
> cluster_getVsvrIdByName().  Two calls.  You don't even need to create
> a function to do it, you can call them directly, and then you don't
> need to worry about naming conventions and my weird ass ideas of
> consistency.

Pfft, who cares how many accesses it has to do?  Oh yeah, this is an
API function.  Please check this new code as I have no idea what I'm
doing.

> > ChrisV
> > 
> > -----Original Message-----
> > From: Andy Sharp 
> > Sent: Tuesday, April 22, 2008 10:12 AM
> > To: Chris Vandever
> > Cc: Rendell Fong
> > Subject: please review 28864
> > 
> > Chris,
> > 
> > I am sending this to you because I want you to review the changes to
> > the cluster api.  You don't have to look at the other files, but
> > you're certainly welcome to if you want to ~:^)
> > 
> > Rendell,
> > 
> > Same goes for you, except the two patch files for exim4.  Again,
> > you're welcome to look at the rest as well.
> > 
> > Thanks,
> > 
> > a
> > 
> > 
> > 
> > Change 28864 by andys@ripper on 2008/04/17 12:57:47 *pending*
> > 
> > 	TED00023344 - autosupport from secondary cluster node not
> > working
> > 	
> > 	Properly obtain the mgmt vsvr id from the cluster API and
> > 	query the DNS with it.
> > 	
> > 	Add a method to the cluster API to return the management
> > vsvr id.
> > 	
> > 	Fix the change that was supposed to shut up the paniclog
> > noise by putting a regex into /etc/default/exim4 that matches
> > anything.
> > 	
> > 	reviewed by
> > 
> > Affected files ...
> > 
> > ... //depot/dev/linux/Pkgs/binary/Deb/exim4-base_4.63-17_mipsel.deb#5
> > edit
> > ... //depot/dev/linux/Pkgs/binary/Deb/exim4-config_4.63-17_all.deb#2
> > edit
> > ...
> >
> //depot/dev/linux/Pkgs/binary/Deb/exim4-daemon-custom_4.63-17_mipsel.deb
> > #6 edit
> > ... //depot/dev/linux/Pkgs/source/exim4/debian.patch#6 edit
> > ... //depot/dev/linux/Pkgs/source/exim4/onstor-vsvr-support.dpatch#2
> > edit
> > ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-vsvr-api.c#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-vsvr-api.h#4 edit
> > 
