AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080425194411.687acdd6@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09624A8B@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 25 Apr 2008 19:44:35 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review 28800
Message-ID: <20080425194435.3d41ce75@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09624A8B@onstor-exch02.onstor.net>
References: <20080414162122.20bfc8ef@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E09624A8B@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 14 Apr 2008 16:27:19 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> You can try it on 10.2.6.7 after it comes up since I'm reboot it now.
> It has a few volumes.

Hi Rendell, say, does this offer still stand?  I never got a chance to
test this crapola before.

Thanks,

a

> -----Original Message-----
> From: Andy Sharp 
> Sent: Monday, April 14, 2008 4:21 PM
> To: Rendell Fong
> Subject: Re: please review 28800
> 
> On Mon, 14 Apr 2008 16:11:55 -0700 "Rendell Fong"
> <rendell.fong@onstor.com> wrote:
> 
> > I guess I'm missing something.  If p doesn't change for each
> > iteration of the while loop how does it ever exit the loop?
> 
> No, you're not missing anything, which is good.
> 
> Fixed.
> 
> I don't suppose you have any filers this code could be run on?  None
> of my filers have storage.
> 
> > 
> > -----Original Message-----
> > From: Andy Sharp 
> > Sent: Monday, April 14, 2008 4:01 PM
> > To: Rendell Fong
> > Subject: Re: please review 28800
> > 
> > On Mon, 14 Apr 2008 15:34:41 -0700 "Rendell Fong"
> > <rendell.fong@onstor.com> wrote:
> > 
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#11 edit
> > > 
> > > Line 2078:  Why delete (p++)?  Doesn't p need to increment to
> > > check each char in location string?
> > 
> > The idea was that, in my estimation, the checking of each component
> > to see if it's individually too long was silly overkill, because I
> > suspect the individual component max is the same as the overall path
> > max.  It was checking the length of each component, and that was
> > passing, but having 100 directories deep was blowing up something
> > below it.
> > 
> > So instead I changed it to check the overall path-max, which it
> > wasn't doing, and to check and make sure it didn't have more than 25
> > (arbitrary) directory components, which would be excessive in my
> > mind.
> > 
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#51 edit
> > > 
> > > Lines 4437-4448: 
> > >   What's the initial value of p and count?  
> > >   Doesn't p need to increment to check each char in location
> > > string?
> > 
> > Same as above, only I fixed the uninitialized variables bug.
> >  
> >  
> > > -----Original Message-----
> > > From: Tim Gardner 
> > > Sent: Monday, April 14, 2008 2:57 PM
> > > To: Rendell Fong
> > > Subject: FW: please review 28800
> > > 
> > >  
> > > Rendell,
> > > 
> > > Can you please do this review.
> > > Thanks.
> > > 
> > > Tim
> > > 
> > > -----Original Message-----
> > > From: Andy Sharp 
> > > Sent: Monday, April 14, 2008 2:52 PM
> > > To: Tim Gardner
> > > Subject: please review 28800
> > > 
> > > Change 28800 by andys@ripper on 2008/04/11 15:59:26 *pending*
> > > 
> > >         TED00023327 - Bus error audit export command with long
> > > path name 
> > >         Egregiously long path name or number of directory
> > > components not being checked for in argument parsing.
> > >         
> > >         reviewed by
> > > 
> > > Affected files ...
> > > 
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#11 edit
> > > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_vol.c#51 edit
> > > 
