AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080428143405.2d6e5196@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C959E@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 28 Apr 2008 14:35:51 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review 29000
Message-ID: <20080428143551.3b5f820a@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C959E@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C959B@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C959E@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 28 Apr 2008 14:17:44 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Forgot to ask, what tests were run on these changes?
> (Complying with new review/check-in requirements...) 

Which I have no intention of paying any attention to...

Except that one.

I did a _system config reset_ with no problems.

> -----Original Message-----
> From: Larry Scheer 
> Sent: Monday, April 28, 2008 2:09 PM
> To: Andy Sharp
> Subject: RE: please review 29000
> 
> nfx-tree/code/ssc-nfxsh/cmd_flash.c
> 
>      Looks good
> 
> nfx-tree/code/ssc-nfxsh/linux.h
> 
>      Looks good
> 
> 
> nfx-tree/code/ssc-nfxsh/openbsd.h
> 
>      Looks good
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Monday, April 28, 2008 1:37 PM
> To: Larry Scheer
> Subject: Re: please review 29000
> 
> On Mon, 28 Apr 2008 12:36:29 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > nfx-tree/code/ssc-nfxsh/linux.h
> > 
> >      Line 105: I don't understand the reason for while (0) {}. --
> >      Just curious...
> 
> Allows you to put a semicolon at the end of the macro, making it look
> more like real code.  Adds just a touch of readability.  I could just
> put curly braces around the whole thing, but I hate that.
> 
> Which reminds me, I forgot to add nfx-tree/code/ssc-nfxsh/cmd_flash.c
> to this changelist.  Duh.
> 
> Resubmit.
> 
> > nfx-tree/code/ssc-nfxsh/openbsd.h
> > 
> >      Line 94: I see the while (0) {} again so it must be
> > intentional; what does this do?
> > 
> > -----Original Message-----
> > From: Andy Sharp 
> > Sent: Monday, April 28, 2008 10:33 AM
> > To: Larry Scheer
> > Subject: please review 29000
> > 
> > Change 29000 by andys@ripper on 2008/04/28 10:30:59 *pending*
> > 
> >         TED 23181 Cougar:system config reset does not bring back the
> > root
> >         or admin password to default value
> >         
> >         Output the error messages to the console as well as the log
> >         so that the user is aware something didn't go right.
> >         
> >         reviewed by
> > 
> > Affected files ...
> > 
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/linux.h#14 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/openbsd.h#14 edit
> > 
