AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080428150214.2afc7f4b@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E099E1835@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 28 Apr 2008 15:02:16 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Subject: Re: Please review
Message-ID: <20080428150216.5c92f616@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E099E1835@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E099E17EB@onstor-exch02.onstor.net>
	<20080428145145.32cad909@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E099E1835@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 28 Apr 2008 14:56:42 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> Here is the test:
> 
> ... //depot/dev/nfx-tree/code/ssc-tests/Makefile#6 edit
> ... //depot/dev/nfx-tree/code/ssc-tests/rmctest.c#1 add

$ p4 fstat nfx-tree/code/ssc-tests/rmctest.c
nfx-tree/code/ssc-tests/rmctest.c - no such file(s).

?

> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Monday, April 28, 2008 2:52 PM
> >To: Maxim Kozlovsky
> >Subject: Re: Please review
> >
> >On Mon, 28 Apr 2008 14:17:49 -0700 "Maxim Kozlovsky"
> ><maxim.kozlovsky@onstor.com> wrote:
> >
> >> Change 29006 by maximk@maximk-13 on 2008/04/28 13:49:40 *pending*
> >>
> >>            Do not call malloc/free functions from the signal
> >> handler in the RMC
> >>            code.
> >>            Reviewed by andys.
> >>
> >> Affected files ...
> >>
> >> ... //depot/dev/nfx-tree/code/ssc-rmc/rmc_pm.c#4 edit
> >>
> >nfx-tree/code/ssc-rmc/rmc_pm.c
> >
> >     what kind of testing have you done with this change?
> 
