AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080429112846.6927ae03@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ron.bhanukitsiri@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#mh/Mailbox/perfarce	0	WEBMAILuQ4GtSFL3WlC00000c25@mail.onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 29 Apr 2008 11:28:56 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Ron Bhanukitsiri <ron.bhanukitsiri@onstor.com>
Subject: Re: PERFORCE change 29026 for review
Message-ID: <20080429112856.14c865fc@ripper.onstor.net>
In-Reply-To: <WEBMAILuQ4GtSFL3WlC00000c25@mail.onstor.com>
References: <WEBMAILuQ4GtSFL3WlC00000c25@mail.onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi Ron,

Just another (ahem) friendly reminder to always include the defect
number as well as what the defect was.  In this case the bug headline
would have been fine.

Thanks!

a


On 29 Apr 2008 11:25:01 -0700 Ron Bhanukitsiri
<ron.bhanukitsiri@onstor.com> wrote:

> Change 29026 by ronb@ronb-dev-local on 2008/04/29 11:20:17
> 
> 	Fix defect 23093.  The problem was caused by incorrect day 1
> implementation of vuid and user_struct handling (inherited from samba
> code) which eventually caused memory overrun and possibly memory
> corruption as well.  The fix is to reimplement and simplified the
> handling that better suits the specific need of ONStor
> authentication.  Also some memory leaks were fixed as positive side
> effects. Reviewed by: jong
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/samba-3.21a/Makefile#4 edit
> ... //depot/dev/nfx-tree/code/samba-3.21a/auth/auth_domain.c#4 edit
> ... //depot/dev/nfx-tree/code/samba-3.21a/nfx/kerb_nfx.c#6 edit
> ... //depot/dev/nfx-tree/code/samba-3.21a/nfx/kerb_util.c#4 edit
> ... //depot/dev/nfx-tree/code/samba-3.21a/nfx/nfx-cifsd-def.h#1 add
> ... //depot/dev/nfx-tree/code/samba-3.21a/nfx/nfx_samba.h#2 edit
> ... //depot/dev/nfx-tree/code/samba-3.21a/nfx/nfx_stats.c#1 add
> ... //depot/dev/nfx-tree/code/samba-3.21a/nfx/nfx_stats.h#1 add
> ... //depot/dev/nfx-tree/code/samba-3.21a/nfx/ntlmv2_nfx.c#6 edit
> ... //depot/dev/nfx-tree/code/samba-3.21a/nfx/reply_nfx.c#10 edit
> 
> 
> http://liszt:1818/@md=d&cd=//depot/$c=G35@/29026?ac=10
