AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080430090720.18c9a4f2@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<sripal.surendiran@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	4817FEB7.5030500@onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 30 Apr 2008 09:07:24 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Sripal <sripal.surendiran@onstor.com>
Subject: Re: File for review
Message-ID: <20080430090724.2a97028c@ripper.onstor.net>
In-Reply-To: <4817FEB7.5030500@onstor.com>
References: <4811A2F6.5060200@onstor.com>
	<481737DE.5000506@onstor.com>
	<20080429092236.64ba6ffe@ripper.onstor.net>
	<4817FEB7.5030500@onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

You're good to go then.  Thanks,

a

On Wed, 30 Apr 2008 10:38:07 +0530 Sripal
<sripal.surendiran@onstor.com> wrote:

> Thanks Andy,
> 
> See my inline comments below.
> 
> -Sripal.
> 
> Andrew Sharp wrote:
> > linux/rootfs/Makefile
> >
> >      i'd like to know if you tested these makefile changes.
> >      specifically, we've found and number of makefile issues
> >      with this makefile this week.  so what you need to do
> >      to test it is to do a "make release" and check to see that
> >      nfx-tree/Build/cg/dbg/Release/onstor/etc/interfaces.org is
> > actually there and contains what you expect.  if you've already
> > done that, just let me know.
> >
> >   
> Sripal> I have tested it already and is making to the Release
> Sripal> directory 
> in the format required.
> > nfx-tree/code/ssc-nfxsh/linux.h
> >
> >      looks good
> >
> >
> >
> > On Tue, 29 Apr 2008 20:29:42 +0530 Sripal
> > <sripal.surendiran@onstor.com> wrote:
> >
> >   
> >> Gentle reminder....
> >>
> >> Thanks,
> >> Sripal.
> >>
> >> Sripal wrote:
> >>     
> >>> Andy,
> >>>
> >>> Please review the following change list.
> >>>
> >>> [sripal@linux-compile ssc-nfxsh]#p4 describe 28964
> >>> Change 28964 by sripal@sripal-rdev on 2008/04/25 02:18:50
> >>> *pending*
> >>>
> >>>        Fix for TED00023178 - system config reset does not reset
> >>> the interface
> >>>        file if the file is corrupted
> >>>
> >>>        Added template interface file in /onstor/etc folder. During
> >>> system config reset, the command will restore the interface file
> >>> from the template file.
> >>>
> >>>        Regression focus:
> >>>        1. Corrupt the /etc/network/interfaces file.
> >>>                a. cp /etc/hosts as /etc/network/interfaces
> >>>                b. delete random lines on
> >>> the /etc/network/interfaces file.
> >>>        2. Do system config reset.
> >>>        3. Answer FTI.
> >>>        4. After boot up, see SC interfaces are properly configured
> >>> as specified in
> >>>        FTI.
> >>>
> >>> Affected files ...
> >>>
> >>> ... //depot/dev/linux/rootfs/Makefile#33 edit
> >>> ... //depot/dev/nfx-tree/code/ssc-nfxsh/linux.h#13 edit
> >>>
> >>> Thanks,
> >>> Sripal.
> >>>
> >>>       
> 
