AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09624AC5@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 30 Apr 2008 09:26:23 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review - change 29032
Message-ID: <20080430092623.217d6c4e@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09624AC5@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E09624AC5@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 29 Apr 2008 17:53:04 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> This change was tested by running system get all/logs on a Bobcat.
> 
> The system get all info was copied to the following directory:
>  
> /n/dw/bycase_onstor_test/case0000001-case0002000/case1234.eng59/eng59,sn
> _0452040003/system_get_all,20080429_17180847
> 
> This verifies that the files as specified in the defect are no longer
> being copied to multiple target directories.
> 
> -------------------------------------------------------
> 
> Change: 29032
> 
> Client: rendellf-test
> 
> User:   rendellf
> 
> Description:
>     TED23019: EMRS - support.sh needs to be updated
> 
>     Fixed support.sh to avoid duplicate copy of auth log, cluster log,
> and     
>     vscan files during system get all/tse/logs cmds.  Display
> appropriate message 
>     when no files are available to be uploaded.
> 
> Files:
>     //depot/dev/nfx-tree/code/ssc-support/support.sh    # edit


nfx-tree/code/ssc-support/support.sh

     line 1762, just use    if [ $# = 0 ]   instead of the pipe.

     line 3230, this is the worst code EVER.  this block of calls to
     put_files_in_target_location.  do all of us a favor and clean
     it up, fix it, etc.  feel free to ask me what i'm talking about.
     i assume the difference between today's version and last night's
     version is the /var/log/onstor/samba stuff?



