AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080501145443.451bfc59@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09624AD4@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 1 May 2008 15:00:35 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review - change 29032
Message-ID: <20080501150035.2879f3a1@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09624AD4@onstor-exch02.onstor.net>
References: <20080430170427.767f4f05@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E09624AD4@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

nfx-tree/code/ssc-support/support.sh


     line 263, sweeeet

     looks OK but i'm guessing you still have one thing left to do
     wrt cron?




On Wed, 30 Apr 2008 19:02:13 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> > line 1764, have you tested this?  
> 
> Yes, tested in both Bobcat and Cougar.  Primarily the all and log
> options.
> Revised again to build a new file list because the specified case
> number scenario was spitting out find errors when no files exist.  
> Also, checked the destination directory where the expected files end
> up.
> 
> > line 3251, this will always not be true in linux, so to save some
>      grief, put an if OPENBSD ; then ... fi around it.
> 
> Done. Are there cron logs for linux?

In syslog; now in messages.

> > line 3292, this needs to be fixed for linux.  correct path is
>      /var/spool/cron/crontabs/root
> 
> Done
> 
> > line 3294, not sure /var/crash is correct path on linux?
> 
> This is the same for linux and openbsd.

hexcellent

> ------------------------
> BOBCAT Cases:
> 
> eng59 diag> system get logs -v vol_mgmt_430
>     Looking for virtual servers and volumes..
>     Virtual server 'VS_MGMT_430' found, and it is Enabled.
>     Created directory
> 'vol_mgmt_430:/system_get_logs,eng59,2008-04-30.31'
>     Updating 'logs_eng59' symlink to: '/logs_eng59 ->
> system_get_logs,eng59,2008-04-30.31'
>     Copying elog message files..             OK
>     Copying syslog files..                   OK
>     Copying auth log files..                 OK
>     Copying ndmp log files..                 OK
>     Copying quota log file..                 OK
>     Copying cron log files..                 OK
>     Copying kpi stats..                      OK
> eng59 diag> system get all -v vol_mgmt_430
>     Looking for virtual servers and volumes..
>     Virtual server 'VS_MGMT_430' found, and it is Enabled.
>     Created directory
> 'vol_mgmt_430:/system_get_all,eng59,2008-04-30.6' Updating
> 'all_eng59' symlink to: '/all_eng59 ->
> system_get_all,eng59,2008-04-30.6' Querying the
> system..................................................................
> ........................................................................
> ........................................................................
> ...............................   OK
>     Copying file sfinfo.xml.gz..             OK
>     Copying elog message files..             OK
>     Copying syslog files..                   OK
>     Copying auth log files..                 OK
>     Copying ndmp log files..                 OK
>     Copying quota log file..                 OK
>     Copying cron log files..                 OK
>     Copying kpi stats..                      OK
>     Copying cron tabs..                      OK
>     Copying crash files..                    OK
>     Copying core files..                     SKIPPED (No files to
> copy) Copying cluster DB..                     OK
> eng59 diag> system get all -c 1234
>     Looking for virtual servers and volumes..
>     Querying the
> system..................................................................
> ........................................................................
> ........................................................................
> ...............................   OK
>     Uploading file sfinfo-20080430_18273045.xml.gz..  OK
>     Uploading elog message files..           OK
>     Uploading syslog files..                 OK
>     Uploading auth log files..               OK
>     Uploading ndmp log files..               OK
>     Uploading quota log file..               OK
>     Uploading cron log files..               OK
>     Uploading kpi stats..                    OK
>     Uploading cron tabs..                    OK
>     Uploading crash files..                  OK
>     Uploading core files..                   SKIPPED (No files to
> copy) Uploading cluster DB..                   OK
> eng59 diag>
> 
> ---------------------
> COUGAR Cases:
> 
> g7r6 diag> system get logs -v vol_mgmt_67413
>     Looking for virtual servers and volumes..
>     Virtual server 'VS_MGMT_67413' found, and it is Enabled.
>     Created directory
> 'vol_mgmt_67413:/system_get_logs,g7r6,2008-05-01.3'
>     Updating 'logs_g7r6' symlink to: '/logs_g7r6 ->
> system_get_logs,g7r6,2008-05-01.3'
>     Copying elog message files..             OK
>     Copying syslog files..                   OK
>     Copying auth log files..                 OK
>     Copying ndmp log files..                 OK
>     Copying quota log file..                 SKIPPED (No files to
> copy) Copying kpi stats..                      OK
> g7r6 diag> system get all -v vol_mgmt_67413
>     Looking for virtual servers and volumes..
>     Virtual server 'VS_MGMT_67413' found, and it is Enabled.
>     Created directory
> 'vol_mgmt_67413:/system_get_all,g7r6,2008-05-01.5' Updating
> 'all_g7r6' symlink to: '/all_g7r6 -> system_get_all,g7r6,2008-05-01.5'
>     Querying the
> system..................................................................
> ........................................................................
> ........................................................................
> ............................................   OK
>     Copying file sfinfo.xml.gz..             OK
>     Copying elog message files..             OK
>     Copying syslog files..                   OK
>     Copying auth log files..                 OK
>     Copying ndmp log files..                 OK
>     Copying quota log file..                 SKIPPED (No files to
> copy) Copying kpi stats..                      OK
>     Copying cron tabs..                      OK
>     Copying crash files..                    OK
>     Copying core files..                     SKIPPED (No files to
> copy) Copying cluster DB..                     OK
> g7r6 diag>
> g7r6 diag> system get all -c 1234
>     Looking for virtual servers and volumes..
>     Querying the
> system..................................................................
> ........................................................................
> ........................................................................
> ............................................   OK
>     Uploading file sfinfo-20080430_18274286.xml.gz..  OK
>     Uploading elog message files..           OK
>     Uploading syslog files..                 OK
>     Uploading auth log files..               OK
>     Uploading ndmp log files..               OK
>     Uploading quota log file..               SKIPPED (No files to
> copy) Uploading kpi stats..                    OK
>     Uploading cron tabs..                    OK
>     Uploading crash files..                  OK
>     Uploading core files..                   SKIPPED (No files to
> copy) Uploading cluster DB..                   OK
> 
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, April 30, 2008 5:04 PM
> To: Rendell Fong
> Subject: Re: please review - change 29032
> 
> nfx-tree/code/ssc-support/support.sh
> 
>      line 1764, have you tested this?  I always worry about setting
>      variables in loops only to have that setting not be relevant
>      outside the loop.  maybe that's only while loops.  but it makes
>      me nervous.  of course you tested it, i'm only joking.  or am i?
> 
>      line 3251, this will always not be true in linux, so to save some
>      grief, put an if OPENBSD ; then ... fi around it.
> 
>      line 3292, this needs to be fixed for linux.  correct path is
>      /var/spool/cron/crontabs/root
> 
>      line 3294, not sure /var/crash is correct path on linux?
> 
> 
> 
> On Wed, 30 Apr 2008 13:25:34 -0700 "Rendell Fong"
> <rendell.fong@onstor.com> wrote:
> 
> > Ok, I my tweaks are done.  The file is in the same place.
> > 
> > 
> > -----Original Message-----
> > From: Andy Sharp 
> > Sent: Wednesday, April 30, 2008 9:26 AM
> > To: Rendell Fong
> > Subject: Re: please review - change 29032
> > 
> > On Tue, 29 Apr 2008 17:53:04 -0700 "Rendell Fong"
> > <rendell.fong@onstor.com> wrote:
> > 
> > > This change was tested by running system get all/logs on a Bobcat.
> > > 
> > > The system get all info was copied to the following directory:
> > >  
> > >
> >
> /n/dw/bycase_onstor_test/case0000001-case0002000/case1234.eng59/eng59,sn
> > > _0452040003/system_get_all,20080429_17180847
> > > 
> > > This verifies that the files as specified in the defect are no
> > > longer being copied to multiple target directories.
> > > 
> > > -------------------------------------------------------
> > > 
> > > Change: 29032
> > > 
> > > Client: rendellf-test
> > > 
> > > User:   rendellf
> > > 
> > > Description:
> > >     TED23019: EMRS - support.sh needs to be updated
> > > 
> > >     Fixed support.sh to avoid duplicate copy of auth log, cluster
> > > log, and     
> > >     vscan files during system get all/tse/logs cmds.  Display
> > > appropriate message 
> > >     when no files are available to be uploaded.
> > > 
> > > Files:
> > >     //depot/dev/nfx-tree/code/ssc-support/support.sh    # edit
> > 
> > 
> > nfx-tree/code/ssc-support/support.sh
> > 
> >      line 1762, just use    if [ $# = 0 ]   instead of the pipe.
> > 
> >      line 3230, this is the worst code EVER.  this block of calls to
> >      put_files_in_target_location.  do all of us a favor and clean
> >      it up, fix it, etc.  feel free to ask me what i'm talking
> > about. i assume the difference between today's version and last
> > night's version is the /var/log/onstor/samba stuff?
> > 
> > 
> > 
