AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080501170100.63e3a8f3@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>,<chris.vandever@onstor.com>,<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 1 May 2008 17:01:23 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Larry Scheer <larry.scheer@onstor.com>
Cc: Chris Vandever <chris.vandever@onstor.com>, Rendell Fong
 <rendell.fong@onstor.com>
Subject: please review 29001
Message-ID: <20080501170123.4412c63c@ripper.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

pick the parts you feel like reviewing.  i sent it to you three for
obvious reasons known only to me.

Change 29001 by andys@ripper on 2008/04/28 10:40:43 *pending*

        TED00022198 - upgrade log file should be located in /var/log/onstor
        
        Somehow these guys {clusServ.log, sys_upgrade.log, vscan} managed
        to escape Agile training day.  Put them where they belong,
        and add to logrotate config file to rotate clusServ.log and vscan.
        
        Have upgrade move the log files to their new home.
        
        Have support.sh upload the files from the correct locations.
        
        TED00023583 - NFXSH SEGFAULT when system upgrade command had typo
        
        This was really fixed in
        changelist#29028 Clear file pointer when it's closed
        but also, don't call fclose() unless there is a file pointer,
        and axe the error message as fclose() can't really fail, and even
        if it could, it wouldn't do us any good to know.
        
        reviewed by

Affected files ...

... //depot/dev/linux/rootfs/etc/logrotate.d/onstor#5 edit
... //depot/dev/nfx-tree/code/sm-elog/elog-api.h#3 edit
... //depot/dev/nfx-tree/code/ssc-cluster/cluster-server.c#7 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_elog.c#10 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#30 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#7 edit
... //depot/dev/nfx-tree/code/ssc-support/support.sh#27 edit

