AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080502113719.17d06206@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<chris.vandever@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E03E9A818@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 2 May 2008 11:38:25 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Chris Vandever" <chris.vandever@onstor.com>
Subject: Re: please review 29001
Message-ID: <20080502113825.6054bab9@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E03E9A818@onstor-exch02.onstor.net>
References: <20080501170123.4412c63c@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E03E9A818@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 1 May 2008 17:51:29 -0700 "Chris Vandever"
<chris.vandever@onstor.com> wrote:

> Not that I would know anything about these, but...
> 
> linux/rootfs/etc/logrotate.d/onstor
> *	@16 do you want clusServ.log here and @30?

Dor.  Fixed.

> *	@41 I'm guessing that's a question, but I don't have an
> answer. I don't even know how to trigger messages to this file, which
> I NEVER look at.  Sorry about that.  As I said before, I'd delete it
> if I could. :-(
> *	Is there an equivalent to logrotate for bsd?

There's newsyslog.  I shall see if I can fix that up.  I was trying to
ignore the BSD side of things because I consider myself too high and
mighty to work on it.

> code/sm-elog/elog-api.h & code/ssc-nfxsh/cmd_elog.c
> *	I'm not sure how vscan is related to elog, but apparently it
> made sense to someone at some time.  Treat this as a general whine
> with no action required on your part.
> 
> ChrisV
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Thursday, May 01, 2008 5:01 PM
> To: Larry Scheer
> Cc: Chris Vandever; Rendell Fong
> Subject: please review 29001
> 
> pick the parts you feel like reviewing.  i sent it to you three for
> obvious reasons known only to me.
> 
> Change 29001 by andys@ripper on 2008/04/28 10:40:43 *pending*
> 
>         TED00022198 - upgrade log file should be located in
> /var/log/onstor
>         
>         Somehow these guys {clusServ.log, sys_upgrade.log, vscan}
> managed
>         to escape Agile training day.  Put them where they belong,
>         and add to logrotate config file to rotate clusServ.log and
> vscan.
>         
>         Have upgrade move the log files to their new home.
>         
>         Have support.sh upload the files from the correct locations.
>         
>         TED00023583 - NFXSH SEGFAULT when system upgrade command had
> typo
>         
>         This was really fixed in
>         changelist#29028 Clear file pointer when it's closed
>         but also, don't call fclose() unless there is a file pointer,
>         and axe the error message as fclose() can't really fail, and
> even
>         if it could, it wouldn't do us any good to know.
>         
>         reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/linux/rootfs/etc/logrotate.d/onstor#5 edit
> ... //depot/dev/nfx-tree/code/sm-elog/elog-api.h#3 edit
> ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-server.c#7 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_elog.c#10 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#30 edit
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#7 edit
> ... //depot/dev/nfx-tree/code/ssc-support/support.sh#27 edit
> 
