AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080502120031.51ad79c3@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C95C7@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 2 May 2008 12:00:50 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review 29001
Message-ID: <20080502120050.22f62040@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C95C7@onstor-exch02.onstor.net>
References: <20080502115337.0eb4f28a@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C95C7@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 2 May 2008 11:56:30 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> I didn't check close enough, did you cd into the directory? I didn't
> see a dirname in front of the cluster logs.

#@$!^#&*&@#$

Fixing now...

> -----Original Message-----
> From: Andy Sharp 
> Sent: Friday, May 02, 2008 11:54 AM
> To: Larry Scheer
> Subject: Re: please review 29001
> 
> On Fri, 2 May 2008 11:43:53 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > linux/rootfs/etc/logrotate.d/onstor
> > 
> >      looks good
> > 
> > nfx-tree/code/sm-elog/elog-api.h
> > 
> >      looks good
> > 
> > nfx-tree/code/ssc-cluster/cluster-server.c
> > 
> >      looks good
> > 
> > nfx-tree/code/ssc-nfxsh/cmd_elog.c
> > 
> >      looks good
> > 
> > nfx-tree/code/ssc-nfxsh/cmd_upgrade.c
> > 
> >      looks good
> > 
> > nfx-tree/code/ssc-nfxsh/verify_install.in
> > 
> >      Line 1147: I think the shell will try to expand the '*' in
> >      clusServ.log* you may need to quote that or escape the * if
> > your intention was to use it as a wildcard in the mv command.
> 
> I do want the shell to expand it right there, so that all the files
> that match it are in the list.  But I'm glad you mentioned that,
> because it made me realize that vscan should also have a * after it,
> because it can be rotated as well.  Actually, Rendell pointed that out
> to me because it needed to change in support.sh as well.  It's a good
> thing I got this reviewed by several people!
> 
> > nfx-tree/code/ssc-support/support.sh
> > 
> >      looks good
> > 
> > -----Original Message-----
> > From: Andy Sharp 
> > Sent: Thursday, May 01, 2008 5:01 PM
> > To: Larry Scheer
> > Cc: Chris Vandever; Rendell Fong
> > Subject: please review 29001
> > 
> > pick the parts you feel like reviewing.  i sent it to you three for
> > obvious reasons known only to me.
> > 
> > Change 29001 by andys@ripper on 2008/04/28 10:40:43 *pending*
> > 
> >         TED00022198 - upgrade log file should be located in
> > /var/log/onstor
> >         
> >         Somehow these guys {clusServ.log, sys_upgrade.log, vscan}
> > managed
> >         to escape Agile training day.  Put them where they belong,
> >         and add to logrotate config file to rotate clusServ.log and
> > vscan.
> >         
> >         Have upgrade move the log files to their new home.
> >         
> >         Have support.sh upload the files from the correct locations.
> >         
> >         TED00023583 - NFXSH SEGFAULT when system upgrade command had
> > typo
> >         
> >         This was really fixed in
> >         changelist#29028 Clear file pointer when it's closed
> >         but also, don't call fclose() unless there is a file
> > pointer, and axe the error message as fclose() can't really fail,
> > and even
> >         if it could, it wouldn't do us any good to know.
> >         
> >         reviewed by
> > 
> > Affected files ...
> > 
> > ... //depot/dev/linux/rootfs/etc/logrotate.d/onstor#5 edit
> > ... //depot/dev/nfx-tree/code/sm-elog/elog-api.h#3 edit
> > ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-server.c#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_elog.c#10 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#30 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/verify_install.in#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-support/support.sh#27 edit
> > 
