AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080505161753.702fbd2d@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 5 May 2008 16:18:15 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Maxim Kozlovsky <maxim.kozlovsky@onstor.com>
Subject: please review 28788
Message-ID: <20080505161815.7801e0ab@ripper.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

In bobcat_mgmt_bus.c, function mgmtbus_irq_free, the first line is in
need of fixin', I'm hoping you know how ~:^)  The rest I'm actually
expecting is not broken.  I've been running the kernel on my cougar for
weeks.  The genlib and nfxsh changes are running on one of the QA
filers and so far no panics.


Change 28788 by andys@ripper on 2008/04/10 14:27:27 *pending*

        TED00023034 - kernel crash: DBE in yenta_irq during shutdown
        
        Implement the device exit method: release the interrupt and
        netdev resources.
        
        Minor message cleanup in mgmtbus_irq_setup.
        
        Currently pursuing the theory that the TXRX is being sent a
        message to reboot/reset, and in doing so, it's resetting the
        PCI bus, which makes the 1125 very unhappy as it might be still
        using it to scribble on the compact flash.
        
        Therefore adding several changes to the code to try and get after
        this problem: ifconfig mgmtbus down in /etc/init.d/onstor and
        exit routine in the mgmtbus driver (probably won't do anything,
        but it makes it possible to run the driver as a module), and
        not bothering to send a reset to the TXRX when doing a shutdown
        because stopping pm will have the equivalent logical effect.
        
        reviewed by

Affected files ...

... //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/bobcat_mgmt_bus.c#4 edit
... //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/cougar_mgmt_bus.c#6 edit
... //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.c#11 edit
... //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.h#5 edit
... //depot/dev/nfx-tree/code/ssc-genlib/Makefile#6 edit
... //depot/dev/nfx-tree/code/ssc-genlib/cm-reboot-linux.c#5 delete
... //depot/dev/nfx-tree/code/ssc-genlib/cm-reboot-openbsd.c#2 delete
... //depot/dev/nfx-tree/code/ssc-genlib/cm-util-bc.c#11 edit
... //depot/dev/nfx-tree/code/ssc-genlib/genlib-linux.c#6 edit
... //depot/dev/nfx-tree/code/ssc-genlib/genlib-openbsd.c#6 edit
... //depot/dev/nfx-tree/code/ssc-genlib/linux.h#6 edit
... //depot/dev/nfx-tree/code/ssc-genlib/openbsd.h#6 edit
... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#45 edit

