AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09C90C0B@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Sun, 11 May 2008 14:53:48 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review - change 29137
Message-ID: <20080511145348.2b655909@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09C90C0B@onstor-exch02.onstor.net>
References: <20080508171831.455b00be@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E09624AFB@onstor-exch02.onstor.net>
	<20080508201309.32657051@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E09C90C0B@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Most definitely.

On Sat, 10 May 2008 18:56:36 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> Ok, I've finished retesting on Cougar and Bobcat.
> Can I check it in?
> 
> 
> -----Original Message-----
> From: Andy Sharp
> Sent: Thu 5/8/2008 8:13 PM
> To: Rendell Fong
> Subject: Re: please review - change 29137
>  
> On Thu, 8 May 2008 18:35:36 -0700 "Rendell Fong"
> <rendell.fong@onstor.com> wrote:
> 
> > See comments below:
> > 
> > >> nfx-tree/code/ssc-support/support.sh
> > 
> > >> nsopt should be: bsd -- "-p tcp" linux -- "--tcp"
> > 
> > Can't use "-p tcp" for BSD, it gives stats instead...
> 
> stupid old openbsd, it works perfectly on the mac
> 
> just "-t" then instead of "-p tcp"
> 
> > eng59# netstat -p tcp
> > tcp:
> >         23367 packets sent
> >                 12126 data packets (4453725 bytes)
> >                 0 data packets (0 bytes) retransmitted
> >                 0 fast retransmitted packets
> >                 10827 ack-only packets (0 delayed)
> >                 0 URG only packets
> >                 0 window probe packets
> >                 4 window update packets
> >                 410 control packets
> >         21296 packets received
> >                 11135 acks (for 4453955 bytes)
> >                 8028 duplicate acks
> >                 0 acks for unsent data
> >                 2748 packets (511283 bytes) received in-sequence
> >                 7749 completely duplicate packets (8218 bytes)
> >                 4 old duplicate packets
> >                 0 packets with some dup. data (0 bytes duped)
> >                 169 out-of-order packets (0 bytes)
> >                 0 packets (0 bytes) of data after window
> >                 0 window probes
> >                 27 window update packets
> >                 0 packets received after close
> >                 0 discarded for bad checksums
> >                 0 discarded for bad header offset fields
> >                 0 discarded because packet too short
> >                 0 discarded for missing IPSec protection
> >         203 connection requests
> >         42 connection accepts
> >         245 connections established (including accepts)
> >         270 connections closed (including 0 drops)
> >         0 embryonic connections dropped
> >         11338 segments updated rtt (of 10365 attempts)
> >         0 retransmit timeouts
> >                 0 connections dropped by rexmit timeout
> >         0 persist timeouts
> >         433 keepalive timeouts
> >                 154 keepalive probes sent
> >                 0 connections dropped by keepalive
> >         7092 correct ACK header predictions
> >         1837 correct data packet header predictions
> >         42 PCB cache misses
> >         0 SYN packets received with same src/dst address/port
> > 
> > 
> > >>  SEPCHAR should be: bsd -- "." linux -- ":"
> > >>  command should be: "`netstat -an $nsopt" | grep
> > $upload_addr$SEPCHAR$upload_port`"
> > 
> > Ok
> > 
> > >>  there should be an upper bound on how high the upload_port gets
> > >>  before this whole nonsense bails.  any arbitrary number is fine.
> > 
> > Added a bounds check.
> > 
> > >>  all those surrounding places in the code that have $var1:$var2:
> > >> and
> > so on,
> > >>  need to have curly braces put around the variable name for bash,
> > because
> > >>  $var:whatever has special meaning to bash, so bash will mess
> > >> this
> > up.
> > >>  so ${var1}:${var2} and like that.
> > 
> > Ok
> > 
> > -----Original Message-----
> > From: Andy Sharp 
> > Sent: Thursday, May 08, 2008 5:19 PM
> > To: Rendell Fong
> > Subject: Re: please review - change 29137
> > 
> > nfx-tree/code/ssc-support/support.sh
> > 
> >      nsopt should be: bsd -- "-p tcp" linux -- "--tcp"
> >      SEPCHAR should be: bsd -- "." linux -- ":"
> >      command should be: "`netstat -an $nsopt" | grep
> > $upload_addr$SEPCHAR$upload_port`"
> > 
> >      there should be an upper bound on how high the upload_port gets
> >      before this whole nonsense bails.  any arbitrary number is
> > fine.
> > 
> > all those surrounding places in the code that have $var1:$var2: and
> > so on,
> > need to have curly braces put around the variable name for bash,
> > because $var:whatever has special meaning to bash, so bash will mess
> > this up. so ${var1}:${var2} and like that.
> > 
> > 
> > 
> > On Wed, 7 May 2008 14:17:48 -0700 "Rendell Fong"
> > <rendell.fong@onstor.com> wrote:
> > 
> > > Change: 29137
> > > 
> > > Client: rendellf-test
> > > User:   rendellf
> > > 
> > > Description:
> > >     TED23575: EMRS: proxy mode gives: Unknown address family `n'
> > > error
> > > 
> > >     Fixed netstat options for Linux.  The netstat -A option has
> > > different
> > >     meaning in Linux and OpenBSD.
> > > 
> > > Files:
> > >     //depot/dev/nfx-tree/code/ssc-support/support.sh    # edit
> > > 
> > > 
> > > Tested proxy enable case in both Bobcat and Cougar:
> > > The following shows that the address family "n" error isn't
> > > occurring anymore.
> > > 
> > > BOBCAT:
> > > eng59 diag> autosupport emrs proxy enable -i 10.0.0.223 -p 3128 -u
> > > test -P tes
> > > eng59 diag> system get logs -c 1234
> > > Network ERROR: the proxy server requires Authentication
> > > % Command failure.
> > > eng59 diag> 
> > > 
> > > COUGAR:
> > > g7r6 diag> autosupport emrs proxy enable -i 10.0.0.223 -p 3128 -u
> > > test -P tes
> > > g7r6 diag> system get logs -c 1234
> > > Network ERROR: the proxy server requires Authentication
> > > % Command failure.
> > > g7r6 diag>
> > > g7r6 diag> autosupport emrs proxy enable -i 10.0.0.223 -p 3128 -u
> > > test -P test
> > > g7r6 diag> system get logs -c 1234
> > >     Uploading elog message files..           OK
> > >     Uploading syslog files..                 OK
> > >     Uploading auth log files..               OK
> > >     Uploading ndmp log files..               OK
> > >     Uploading quota log file..               SKIPPED (No files to
> > > copy) Uploading kpi stats..                    OK
> > > g7r6 diag>
> 
