AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070307125143.37f0d4b4@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E02B75169@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 7 Mar 2007 12:52:37 -0800
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Ed Kwan" <ed.kwan@onstor.com>
Subject: Re: please review code change for TED 17792 (was 17992)
Message-ID: <20070307125237.733d488c@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E02B75169@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E02B74EB0@onstor-exch02.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E02B74EBB@onstor-exch02.onstor.net>
	<20070306175840.7a869f9a@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E02B75169@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

OK, can you tell me what it is and also include a diff?  I'll be happy
to review it.

Cheers,

a

On Wed, 7 Mar 2007 10:09:29 -0800 "Ed Kwan" <ed.kwan@onstor.com> wrote:

> Sorry.  Typo.  TED 17792 Great West Life-4654]-Filer crashed
> 
> > -----Original Message-----
> > From: Andy Sharp
> > Sent: Tuesday, March 06, 2007 5:59 PM
> > To: Brian DeForest
> > Cc: Ed Kwan; Larry Scheer
> > Subject: Re: please review code change for TED 17992
> > 
> > What is TED 17992?
> > 
> > Thanks,
> > 
> > a
> > 
> > On Tue, 6 Mar 2007 17:27:52 -0800 "Brian DeForest"
> > <brian.deforest@onstor.com> wrote:
> > 
> > > Ed, I need to leave early and will be offline for a while.   Larry
> or
> > > Andy, can one of you review this for Ed?
> > >
> > > _____________________________________________
> > > From: Ed Kwan
> > > Sent: Tuesday, March 06, 2007 5:26 PM
> > > To: Brian DeForest
> > > Subject: please review code change for TED
> > >
> > > Hi Brian,
> > >
> > > Client name: edk-delorean
> > > File: openbsd/src/sys/kern/uipc_usrreq.c
> > >
> > > My change is based on the following change in OpenBSD:
> > >
> > > Revision 1.29
> > >
> <http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?rev=1.
> > > 29&content-type=text/x-cvsweb-markup>  / (download
> > >
> <http://www.openbsd.org/cgi-bin/cvsweb/~checkout~/src/sys/kern/uipc_usrr
> > > eq.c?rev=1.29&content-type=text/plain> ) - annotate
> > >
> <http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?annota
> > > te=1.29>  - [select for diffs]
> > >
> <http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?r1=1.2
> > > 9>  , Tue May 17 21:43:08 2005 UTC (21 months, 2 weeks ago) by
> > > 9> fgsch
> > > Branch: MAIN
> > >
> <http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?only_w
> > > ith_tag=MAIN>
> > > CVS Tags: OPENBSD_3_8_BASE
> > >
> <http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?only_w
> > > ith_tag=OPENBSD_3_8_BASE>
> > > Branch point for: OPENBSD_3_8
> > >
> <http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c?only_w
> > > ith_tag=OPENBSD_3_8>
> > > Changes since 1.28: +3 -1 lines
> > > Diff to previous 1.28
> > >
> <http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c.diff?r
> > > 1=1.28&r2=1.29>  (colored
> > >
> <http://www.openbsd.org/cgi-bin/cvsweb/src/sys/kern/uipc_usrreq.c.diff?r
> > > 1=1.28&r2=1.29&f=h> )
> > > under some circunstances, unp_scan() can call unp_mark() with a
> > > null pointer,
> > > so check fp before dereferencing it; fixes a crash found by
> hshoexer@
> > > with input from art@, art@ millert@ deraadt@ ok.
> > >
> > >
> > > Thanks,
> > > Ed
> > >
> > >
