AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080515105750.22e71fbb@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<tim.gardner@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09FCECEB@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 15 May 2008 10:58:02 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Tim Gardner" <tim.gardner@onstor.com>
Subject: Re: please review 29217
Message-ID: <20080515105802.722cacf9@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09FCECEB@onstor-exch02.onstor.net>
References: <20080514191154.7911e1ce@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E09FCECEB@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

compile tested on cougar/cheetah.  cheetah still broken on sm-except.


On Wed, 14 May 2008 20:55:04 -0700 "Tim Gardner"
<tim.gardner@onstor.com> wrote:

> genlib-openbsd.c
> 32: get rid of all this code that is commented out. FYI: #if 0 /
> #endif is easier.

Dead code removed.

> 78: more dead code; delete it

78?
 
> cmd_promupgrade.c
> 1189: why ignore the fclose return value. cast it to (void) is you
> really want to ignore it.

Convention is not to cast system calls to void return, especially
system calls that have little or no value to their return value.

> cmd_system.c
> 381: this concerns me. think you explained it to me once. need to hear
> it again.

Really on Bobcat and Cougar, there is no need to send a message to the
embedded processors to halt, they will get a reset from when the SSC
resets.  On cougar, this seems to be causing the TXRX to reset while
the SSC is still running, and that causes a PCI bus reset, which
crashes the kernel when it tries to access the compact flash.

> cmd_upgrade.c
> 1390: two blank lines not enough huh?

fixed.

> 1408,1420: why the change from using my_print which is used all
> through this file?

fixed.

> Need some comments here why this function is only defined for cheetah.

fixed.

> 2409: extra line

removed multiple blank lines at the end of the file

> genlib.c
> 27: remove dead code

fixed

> 107: more dead code

fixed

> 205: and yet more unused code

fixed

> Nice job. Glad to see the death of the duplicate pm code.
> 
> > -----Original Message-----
> > From: Andy Sharp
> > Sent: Wednesday, May 14, 2008 7:12 PM
> > To: Tim Gardner
> > Subject: please review 29217
> > 
> > Built and tested on: Cougar, Bobcat/BSD, Cheetah/BSD
> > Built on Bobcat/Linux
> > 
> > Testing: system config reset (causes a reboot)
> >          system reboot
> >          system reboot -s
> >          system config copy;system config restore (causes a reboot)
> >          CLI FTI (causes a reboot)
> > 
> > Not tested:
> > 
> >     I can't tell if an individual board on a Cheetah has ~not~
> >     been rebooted when I hope it has.  But regular reboots seem to
> >     work, and I get this output:
> > Slot 1 rebooted
> > Slot 2 rebooted
> >     so I'm hopeful.
> > 
> >     system reset ssc (on Cheetahs) - I can't find the
> >     command although it seems to be in the code.
> > 
> > 
> > 
> > Change 29217 by andys@ripper on 2008/05/13 16:51:57 *pending*
> > 
> >         Properly fix build problem on sabre tooth - and try to clean
> up
> >         code in SSC that reboots the system by coalescing as much of
> it
> >         as possible to one generic place that is more sanely
> maintainable.
> > 
> >         This is a continuation of change 29108 which attempts to
> > deal
> with
> > 
> >         >TED00023034 - kernel crash: DBE in yenta_irq during
> >         >shutdown
> > 
> >         by changing the way we reboot cougar.  It turns out there
> > were a couple of other places in our code that reboot the system in
> >         their own private little ways.
> > 
> >         reviewed by
> > 
> > Affected files ...
> > 
> > ... //depot/dev/linux/kernel/linux-mips-2.6/.git/index#9 edit
> > ... //depot/dev/linux/kernel/linux-mips-
> > 2.6/.git/objects/34/fad0113ebaca1d4983577e6a52dd8827a86e4b#1 add
> > ... //depot/dev/linux/kernel/linux-mips-
> > 2.6/.git/objects/55/456bc4702b7bad291f1f5c959811042fa2f432#1 add
> > ... //depot/dev/linux/kernel/linux-mips-
> > 2.6/.git/objects/6e/0ef3fa3742fe19dfda7b55dd2682cd0f748afe#1 add
> > ... //depot/dev/linux/kernel/linux-mips-
> > 2.6/.git/objects/70/8d47f1f69eb3f589015f1c6bd8465e6becfb81#1 add
> > ... //depot/dev/linux/kernel/linux-mips-
> > 2.6/.git/objects/f8/d80420def2316ffa7a62271c232a2209f3b9a5#1 add
> > ... //depot/dev/linux/kernel/linux-mips-2.6/.git/refs/heads/onstor-
> > 2.6.22#5 edit
> > ... //depot/dev/nfx-tree/code/sm-sct/taskmgr.c#18 edit
> > ... //depot/dev/nfx-tree/code/ssc-cluster/cluster-util.c#13 edit
> > ... //depot/dev/nfx-tree/code/ssc-genlib/Makefile#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-genlib/cm-util-bc.c#12 edit
> > ... //depot/dev/nfx-tree/code/ssc-genlib/genlib-linux.c#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-genlib/genlib-openbsd.c#8 edit
> > ... //depot/dev/nfx-tree/code/ssc-genlib/genlib.c#1 add
> > ... //depot/dev/nfx-tree/code/ssc-genlib/genlib.h#6 edit
> > ... //depot/dev/nfx-tree/code/ssc-genlib/linux.h#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-genlib/openbsd.h#7 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#16 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_promupgrade.c#12 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c#46 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_upgrade.c#31 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/nfxsh.h#9 edit
> > ... //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh_initial.c#1 edit
> > ... //depot/dev/nfx-tree/code/ssc-pm/linux.c#6 edit
> > ... //depot/dev/nfx-tree/code/ssc-pm/openbsd.c#6 edit
> > ... //depot/dev/nfx-tree/code/ssc-pm/pm.c#15 edit
> > ... //depot/dev/nfx-tree/code/ssc-pm/pm.h#8 edit
