AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080520100403.469b603c@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09624B08@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 20 May 2008 10:04:17 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review 29277
Message-ID: <20080520100417.15dc2aaa@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09624B08@onstor-exch02.onstor.net>
References: <20080519102118.1d9da2e9@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E09624B08@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi Rendell,

OK, I need to ask you to rereview this, as after I resolved it and
tested the result, emrs was completely broken by some other checkin, so
I've added a fix to that issue as well, as well as one other where
uploads on Linux can get rejected because grep was matching more
processes than I guess people thought would be running.

Thanks,

a

On Mon, 19 May 2008 12:09:11 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> Ok - I assume you've checked the output that's being generated for the
> bogus printf fix.
> 
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Monday, May 19, 2008 10:21 AM
> To: Rendell Fong
> Subject: please review 29277
> 
> Change 29277 by andys@ripper on 2008/05/16 13:41:03 *pending*
> 
>         TED00022685 - elogs not uploaded to ERMS on logrotate
>         
>         Remove the code for Linux that attempts to wait on logrotate
>         because I suspect it's not working, and because it isn't
> needed. What are the chances that someone will fire an elog upload by
>         hand at the exact mllisecond logrotate rotates the file at
> 6.25am?
>         What are the chances anyone will care, since the first might
>         have a problem, but then the log will immediately get uploaded
>         by logrotate?  Zero to none.
>         
>         TED00023450 - EMRS is not uploading config file nightly
>         
>         Bogus printf syntax fixed.  Should have been broken on BSD as
>         well but I guess no one noticed.
>         
>         reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-support/emrscron#21 edit
> 
