AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080520165626.782bef5a@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0A0F8ABC@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 20 May 2008 16:56:36 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Ed Kwan" <ed.kwan@onstor.com>
Subject: Re: Please review code change for TED 21181
Message-ID: <20080520165636.0d0382ac@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0A0F8ABC@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0A0F893D@onstor-exch02.onstor.net>
	<20080520161707.299369f7@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0A0F8ABC@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 20 May 2008 16:26:12 -0700 "Ed Kwan" <ed.kwan@onstor.com> wrote:

> Removed.
> 
> > -----Original Message-----
> > From: Andy Sharp
> > Sent: Tuesday, May 20, 2008 4:17 PM
> > To: Ed Kwan
> > Subject: Re: Please review code change for TED 21181
> > 
> > You need to remove the Host line from this perforce client.
> > 
> > On Tue, 20 May 2008 12:14:32 -0700 "Ed Kwan" <ed.kwan@onstor.com>
> wrote:
> > 
> > > Pending change 29328
> > >
> > > [edk@edk-linux Tools]$ p4 info
> > > User name: edk
> > > Client name: edk-r311rel
> > > Client host: edk-linux.onstor.net
> > > Client root: /homes/edk/p4/r311rel
> > > Current directory: /homes/edk/p4/r311rel/nfx-tree/Tools
> > > Client address: 10.0.0.137:40470
> > > Server address: p4.onstor.net:1717
> > > Server root: /p4data/p4root
> > > Server date: 2008/05/20 12:13:20 -0700 PDT
> > > Server version: P4D/LINUX26X86_64/2007.2/122958 (2007/05/23)
> > > Server license: ONStor 40 users (support expired 2008/05/15)
> > >
> > > [edk@edk-linux Tools]$ p4 opened
> > > //depot/r311rel/nfx-tree/Tools/cw_install.in#1 - edit change 29328
> > > (xtext)
> > >
> > > My tests are running the install script in both interactive and
> > > non-interactive modes.




nfx-tree/Tools/cw_install.in

     line 854  for maintenance reasons, there should only be one
     tar command:

     if "$imode" then
     	V=-v
	TAR_CHATTER_CMD="| awk ' BEGIN { cnt=0 } { if ( (++cnt % 500 ) == 0 ) { print cnt " files extracted" } } '"
     else
     	V=
	TAR_CHATTER_CMD=
     fi

     nice -n 15 tar $V -zxpf "${tdir}/${tball}" -s '+./usr/local/agile$++' \
     			-s '+./usr/man/.*++' -s '+./usr/local/man/.*++' . $TAR_CHATTER_CMD




     line 926

     I would leave this area alone, except make it a loop, and make the
     case exactly match yes or no, or loop around and ask again, so as
     to take care of the possible garbage the user might have entered.
     Allow no default -- that defeats the purpose if it dumps out of
     the shell script and the user wanted to reboot.  Or vice versa.
     But I leave that up to you.

