AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080521085859.0f4ac71f@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0A0F8C18@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 21 May 2008 08:59:26 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Ed Kwan" <ed.kwan@onstor.com>
Subject: Re: Please review code change for TED 21181
Message-ID: <20080521085926.5b7ec5c5@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0A0F8C18@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0A0F893D@onstor-exch02.onstor.net>
	<20080520161707.299369f7@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0A0F8ABC@onstor-exch02.onstor.net>
	<20080520165636.0d0382ac@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0A0F8B78@onstor-exch02.onstor.net>
	<20080520210815.04d3679d@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0A0F8C18@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

	       3.  Change the default answer to the question "reboot
the system now?" to "No".
	
Probably want to fix that last part of the comment.

nfx-tree/Tools/cw_install.in

     no|No|NO

     I like your style.

     Looks good.



On Tue, 20 May 2008 22:52:52 -0700 "Ed Kwan" <ed.kwan@onstor.com> wrote:

> I made both changes that you recommended.  Please review again.
> Thanks!
> 
> > -----Original Message-----
> > From: Andy Sharp
> > Sent: Tuesday, May 20, 2008 9:08 PM
> > To: Ed Kwan
> > Subject: Re: Please review code change for TED 21181
> > 
> > On Tue, 20 May 2008 18:41:06 -0700 "Ed Kwan" <ed.kwan@onstor.com>
> wrote:
> > 
> > > Hi Andy,
> > >
> > > Don't think you can put a pipe command in a variable.
> > >
> > > eng236# cat s
> > > #!/bin/sh
> > > PCMD="| wc"
> > > ls $PCMD
> > 
> > eval ls $PCMD
> > 
> > sorry, forgot the eval
> > 
> > >
> > > eng236# ./s
> > > ls: wc: No such file or directory
> > > ls: |: No such file or directory
> > >
> > > Ed
> > >
> > > > nfx-tree/Tools/cw_install.in
> > > >
> > > >      line 854  for maintenance reasons, there should only be one
> > > >      tar command:
> > > >
> > > >      if "$imode" then
> > > >      	V=-v
> > > > 	TAR_CHATTER_CMD="| awk ' BEGIN { cnt=0 } { if ( (++cnt %
> > > > 500 )
> > > == 0
> > > > ) { print cnt " files extracted" } } '"
> > > >      else
> > > >      	V=
> > > > 	TAR_CHATTER_CMD=
> > > >      fi
> > > >
> > > >      nice -n 15 tar $V -zxpf "${tdir}/${tball}" -s
> > > '+./usr/local/agile$++'
> > > > \
> > > >      			-s '+./usr/man/.*++' -s
> > > > '+./usr/local/man/.*++'
> > > .
> > > > $TAR_CHATTER_CMD
> > > >
> > >
