AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080525150616.4eb505b9@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E042F01AB@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Sun, 25 May 2008 15:06:30 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: Please review change list 29101
Message-ID: <20080525150630.5633e1e3@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E042F01AB@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E056C9648@onstor-exch02.onstor.net>
	<20080524162808.1604ea8c@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E042F01AB@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hmm, that does ring one or two bells in my walnut sized brain.  Let me
take a look...

On Sun, 25 May 2008 14:25:01 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> You did review it a couple/few weeks back. Check your devnotes
> directory. I've been sitting on this change list for a while. If I am
> mistaken then please review this change. 
> 
> I know we talked about it because I reverted my changes
> to /etc/init.d/networking that echoed std error to /var/log/dmesg
> based on your recommendation.
> 
> Larry
> 
> -----Original Message-----
> From: Andy Sharp
> Sent: Sat 5/24/2008 4:28 PM
> To: Larry Scheer
> Subject: Re: Please review change list 29101
>  
> I don't recall reviewing this stuff, at least not for a couple weeks.
> 
> On Fri, 23 May 2008 21:23:45 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > Sripal,
> >    Please review these changes. Andy Sharp has already reviewed
> > them; however I would like to have you look at the changes as well.
> > 
> > My workspace is on linux-compile in the directory:
> > /home/larrys/perforce/trees/dev
> > 
> > You can run p4v on linux-compile to view the change list by
> > selecting my larrys-r14-dmip client and setting the user to larrys.
> > 
> > These changes to the interfaces file are necessary to remove the
> > boot time messages. The defect 23467 also includes boot time
> > messages that are caused by how we implemented the addroutes file.
> > So more changes are needed to clean up those messages and do the
> > adding of a default route and static routes correctly. However
> > changing addroutes has a greater impact on the project so this work
> > is being done in stages. 
> > Change 29101 by larrys@larrys-r14-dmip on 2008/05/05 18:56:18
> > *pending*
> > 
> >         TED00023467 Clean up messages at boot time
> >         Change network/interfaces file to comment out the auto line
> > for unconfigured interfaces. This eliminates messages:
> >                 address: Unknown host
> >                 ifconfig: `--help' gives usage information.
> >                 Failed to bring up eth1.
> > 
> >         Reviewed by: AndyS
> > 
> > Affected files ...
> > 
> > ... //depot/dev/linux/rootfs/etc/init.d/onstor-config#4 edit
> > ... //depot/dev/linux/rootfs/etc/network/interfaces#3 edit
> > ...
> > //depot/dev/nfx-tree/code/ssc-initial-config/initial-config-linux.c#2
> > edit
> > ... //depot/dev/nfx-tree/code/ssc-initial-config/migrate.sh#1 edit
> > 
> > Thanks,
> > 
> > Larry
> 
