AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080606125353.4c82b4f7@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C9687@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Fri, 6 Jun 2008 12:54:15 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review 29513
Message-ID: <20080606125415.744f14f1@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C9687@onstor-exch02.onstor.net>
References: <20080605155038.3c57d994@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C9687@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 5 Jun 2008 17:18:44 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> linux/rootfs/etc/init.d/cfmon
> 
>      >>add linux/rootfs/etc/init.d/cfmon
> 
> linux/rootfs/etc/init.d/rcS
> 
>      looks good
> 
> nfx-tree/code/ssc-cfmond/Makefile
> 
>      >>add nfx-tree/code/ssc-cfmond/Makefile This Makefile will fail
>      because there is no ../../cg/{bin,opt}/bin directory

nah, what I want is ../../Build/cg/{opt,dbg}/bin

all this other stuff is too complicated for this little PoS

>      What you want is:
> 
>      # Copyright (c) 2000 - 2008 ONStor Inc..
>      # ALL RIGHTS RESERVED
> 
>      PATH_TO_ROOT    := ../..
> 
>      include $(PATH_TO_ROOT)/Tools/init-ssc.mk
> 
>      include $(PATH_TO_ROOT)/Tools/defs.mk
> 
>      TARGET_EXT := .sh 
> 
>      APP        := cfmod
> 
>      TARGETS    := $(APP:%=$(BINDIR)/%$(TARGET_EXT))
> 
>      default all: $(BINDIR) $(TARGETS)
> 
>      #get the clean targets
> 
>      include $(PATH_TO_TOOLS)/suffix.mk
> 
> nfx-tree/code/ssc-cfmond/cfmond.c
> 
>      >>add nfx-tree/code/ssc-cfmond/cfmond.c
> 
>      Fine.
> 
> nfx-tree/code/ssc-cfmond/cfmond.sh
> 
>      >>add nfx-tree/code/ssc-cfmond/cfmond.sh
> 
>      Line 46 if $1 is not set you will get a syntax error from expr. I
>      know you don't call clean_var without an agrument, but who knows
>      what some other yea-hoo might do when you are not looking?

Well, the error has to go somewhere, might as well go here.  I put
double quotes around the $1 so now it gives "expr: non-numeric
argument" instead of syntax error.  Which is better maybe.

>      Line 123 Is 15 seconds long enough to sleep? Just asking... Are
> all the clean_var tasks serialized so there is no possibility another
>      clean_var will be invoked before the previous one finishes? Again
>      just asking...

I'll put in some error checking here.  Shouldn't do the same filesystem
twice in a loop.  Now, how to go about doing that...

> nfx-tree/linux.mk
> 
>      looks good
> 
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Thursday, June 05, 2008 3:51 PM
> To: Larry Scheer
> Subject: please review 29513
> 
> Change 29513 by andys@ripper on 2008/06/03 16:59:19 *pending*
> 
> 	TED00023847 - if /var is full then elogs will stop
> 	
> 	Add a shell script that runs as a daemon.  Ideally, a proper C
> 	program with config file specifying filesystem events to watch
> 	and actions to take, would be the most desireable, but for
> now a quick shell script just to deal with filesystems being full will
> 	have to do.  I was going to write the C program, but I wanted
> 	to make the config file be in XML, but that would cause a new
> 	package to be pulled into the root filesystem ... so I wrote a
> 	quick shell script instead.
> 	
> 	reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/linux/rootfs/etc/init.d/cfmon#1 add
> ... //depot/dev/linux/rootfs/etc/init.d/rcS#8 edit
> ... //depot/dev/nfx-tree/code/ssc-cfmond/Makefile#1 add
> ... //depot/dev/nfx-tree/code/ssc-cfmond/cfmond.c#1 add
> ... //depot/dev/nfx-tree/code/ssc-cfmond/cfmond.sh#1 add
> ... //depot/dev/nfx-tree/linux.mk#3 edit
> 
