AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080610173025.7a41af30@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09624B4B@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 10 Jun 2008 17:30:52 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review 29371
Message-ID: <20080610173052.4b317f84@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09624B4B@onstor-exch02.onstor.net>
References: <20080610164042.47bc86b1@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E09624B4B@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 10 Jun 2008 17:10:35 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> 1) I just want point out that another way of doing this is by checking
> the autosupport cfg is via cluster DB api instead of sending another
> request.  In fact, asd does this prior to checking if enabled and
> sending the AS Report when it receives the AS_GENERATE_REPORT
> request. 
> 
>    as_config_t asCfg;
>    if ((cluster_getAutoSupport(&asCfg) == NFX_OK) && (asCfg.enable)) {
> 	/* send AS_GENERATE_REPORT req */
>    }

I'll leave it like it is, just to modular and to match the surrounding
code.

> However, it should work either way so it's up to you.
> 
> 2) Line 1645: printf("Verify autosupport mode.  Blah,blah,blah...
> 
> Does this error message need to be updated as well?
> Since autosupport mode should be enabled at this point, the only
> reason it could fail is due to some internal error (mail queue is
> full, memory alloc error, or some email send error). No need to
> verify the mode anymore.

OK, I cleaned up this logic a bit, including returning CMD_ERR_FAILED
if eventCfgRsp is negative instead of returning CMD_SUCCESS.


> -----Original Message-----
> From: Andy Sharp 
> Sent: Tuesday, June 10, 2008 4:41 PM
> To: Rendell Fong
> Subject: please review 29371
> 
> Change 29371 by andys@ripper on 2008/05/21 16:49:46 *pending*
> 
>         Fix autosupport command that generates a report to inform the
>         user if the autosupport feature has not been enabled.
>         
>         reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_autosupport.c#14 edit
