AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080611103815.6ce58753@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ian.brown@onstor.com>,<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	B5C426A9-9AEA-4A25-A848-BA3860722672@onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 11 Jun 2008 10:39:07 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Ian Brown <ian.brown@onstor.com>
Cc: Larry Scheer <larry.scheer@onstor.com>
Subject: Re: please review 29301
Message-ID: <20080611103907.018c6520@ripper.onstor.net>
In-Reply-To: <B5C426A9-9AEA-4A25-A848-BA3860722672@onstor.com>
References: <20080610165037.6310f578@ripper.onstor.net>
	<B5C426A9-9AEA-4A25-A848-BA3860722672@onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Get well soon ~:^)

Linux, and ssl and socat on Linux, don't suffer from those problems.
Let's talk about the rest of it this afternoon if you're around.

Cheers,

a

On Tue, 10 Jun 2008 19:29:13 -0700 Ian Brown <ian.brown@onstor.com>
wrote:

> Hey andy, I see some problems with this, since:
> 1) I fixed some bugs that we had in socat, with the way it didn't  
> handle errors in the SSL code.  These may have only shown up because  
> of the interaction with bsd, but it did happen with customers that
> had proxies which made packets fragmented, small and latent.
> 
> 2) I some of the code in support.sh queues off of the error messages  
> in socat, and the format of socat error messages changes between  
> bobcat socat and the new one.  I have already fixed 80% of the most  
> common ones of these and have tests for them in the test suite.
> 
> Once I get my cougar installed and get done being sick :P , I will  
> take your code and run it through various tests and write some tests  
> for it.
> 
> Ian
> 
> 
> On Jun 10, 2008, at 4:50 PM, Andrew Sharp wrote:
> 
> Hi Guys,
> 
> Larry, could you review the Makefile changes in this changelist?
> 
> Ian, could you please review the emrscron and support.sh changes?
> 
> As always, everyone may feel free to review all the files in the
> changelist as well as the requested ones.
> 
> Thanks,
> 
> a
> 
> 
> Testing: this has been testing for several weeks on both a Bobcat/BSD
> and a Cougar, focusing mainly on working when invoked from cron, but
> also when invoked from the cli.
> 
> 
> Change 29301 by andys@ripper on 2008/05/19 09:46:29 *pending*
> 
>         TED0002383 - BSD socat being installed and used on Linux build
> 
>         BSD socat removed from Linux build.
> 
>         A timeout framework put in place in support.sh to properly  
> handle
>         timing out connections to the phd server, including noting
> that failure in the logs.
> 
>         Fix numerous other problems with support.sh, for example, no
>         logs or upgrade logs from secondary flash have been working
>         since 3.0, and certainly never worked in Linux.
> 
>         Some additional error logging added.
> 
>         reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/Makefile.ssc#12 edit
> ... //depot/dev/nfx-tree/code/ssc-support/emrscron#22 edit
> ... //depot/dev/nfx-tree/code/ssc-support/support.sh#32 edit
> ... //depot/dev/nfx-tree/openbsd.mk#6 edit
> 
> 
