AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<chris.vandever@onstor.com>,<jonathan.goldick@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E03E9A8EC@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 12 Jun 2008 12:03:01 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Chris Vandever" <chris.vandever@onstor.com>, Jonathan Goldick
 <jonathan.goldick@onstor.com>
Subject: Re: Code Review Request
Message-ID: <20080612120301.4cb8f430@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E03E9A8EC@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E03E9A8EC@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 11 Jun 2008 20:54:06 -0700 "Chris Vandever"
<chris.vandever@onstor.com> wrote:

> The code is in ~chrisv/p4/dev3/nfx-tree/061108CodeReview and in my p4
> client, chrisv-dev3.
> 
> ---------------
> 
> code/sm-gns/gns-api.c
> code/sm-utils/sys-utils.c
> code/sm-utils/sys-utils-api.h
> code/ssc-cluster/cluster-api.h
> code/ssc-cluster/cluster-contrl-cfg.c
> code/ssc-cluster/cluster-gns-api.c
> code/ssc-cluster/cluster-server-rpc.c
> code/ssc-cluster/cluster-util.c
> code/ssc-cluster/cluster-util.h
> code/ssc-cluster/cluster-vsvr-api.c
> 
> Prerequisite for #23399 (clustering needs to restart apps when it
> gets a new clusDb): Create a utility function apps can call to
> initiate a reboot, with all of the appropriate notifications
> regarding the reason for the reboot.  Eliminate the function in
> clustering that does the same thing, incorrectly.
> 
> ---------------



>	Prerequisite for #23399 (clustering needs to restart apps when

OK, I'll play, what is a 23399?  Oh, it's a bug number!  Hokay!

>	it gets a new clusDb): Create a utility function apps can call
>	to initiate a reboot, with all of the appropriate notifications
>	regarding the reason for the reboot.  Eliminate the function
>	in clustering that does the same thing, incorrectly.

Forgive my question, but why can't it actually just restart the apps?
Kill pm, wait a semi-heartbeat, and restart pm?  Something like that?



nfx-tree/code/sm-gns/gns-api.c

     looks good

nfx-tree/code/sm-utils/sys-utils-api.h

     looks good

nfx-tree/code/sm-utils/sys-utils.c

     line 23, i might be blind, but i can't find where this file
     needs sys/stat.h



nfx-tree/code/ssc-cluster/cluster-api.h

     looks good

nfx-tree/code/ssc-cluster/cluster-contrl-cfg.c

     looks good

nfx-tree/code/ssc-cluster/cluster-gns-api.c

     looks good

nfx-tree/code/ssc-cluster/cluster-server-rpc.c

     looks good

nfx-tree/code/ssc-cluster/cluster-util.c

     looks good

nfx-tree/code/ssc-cluster/cluster-util.h

     looks good

nfx-tree/code/ssc-cluster/cluster-vsvr-api.c

     looks good


