AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080612214206.63d412b2@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09624B51@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Thu, 12 Jun 2008 21:42:08 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review  - change 29638, 29641,29657
Message-ID: <20080612214208.6fd591b0@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09624B51@onstor-exch02.onstor.net>
References: <20080612182150.6538090a@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E09624B51@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

cool

On Thu, 12 Jun 2008 20:49:54 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> See inline comments... RF
> 
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Thursday, June 12, 2008 6:22 PM
> To: Rendell Fong
> Subject: Re: please review - change 29638, 29641,29657
> 
> On Thu, 12 Jun 2008 17:43:59 -0700 "Rendell Fong"
> <rendell.fong@onstor.com> wrote:
> 
> > Change: 29657
> > 
> > Client: rendellf-test
> > 
> > User:   rendellf
> > 
> > Description:
> >     TED23928: autosupport schedule options should be independently
> > set
> > 
> >     Changed to retain existing schedule options when not specified
> > in command.
> >     Update help for autosupport schedule command.
> > 
> > Files:
> >     //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_autosupport.c   # edit
> > 
> > _____________________________________________
> > From: Rendell Fong 
> > Sent: Wednesday, June 11, 2008 6:12 PM
> > To: Andy Sharp
> > Subject: please review - change 29638, 29641
> > 
> > Change: 29638
> > 
> > Client: rendellf-test
> > 
> > User:   rendellf
> > 
> > Description:
> >     TED22011: Cougar: arp show displays invalid entry inconsistently
> > 
> >     Changed arp info response to set vsvr interface name to NULL
> > string so that
> >     CLI arp show cmd (for SSC) properly displays the arp entry
> > interface name.
> > 
> > Files:
> >     //depot/dev/nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.c  # edit
> >     //depot/dev/nfx-tree/code/ssc-ifconfig/ssc-ifc-openbsd.c    #
> > edit
> > 
> > 
> > Change: 29641
> > 
> > Client: rendellf-test
> > 
> > User:   rendellf
> > 
> > Description:
> >     TED22577: Cougar : Invalid entries in "system show users"
> > command
> > 
> >     Changes to validate logged-in user info entries before
> > displaying them.
> > 
> > Files:
> >     //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-linux.c  # edit
> >     //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c    #
> > edit //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_system.c    # edit
> >     //depot/dev/nfx-tree/code/ssc-nfxsh/nfxsh.h # edit
> > 
> 
> 
> > Change 29638 by rendellf@rendellf-test on 2008/06/11 15:30:24
> > *pending*
> >
> >	TED22011: Cougar: arp show displays invalid entry
> >	inconsistently
> >
> >	Changed arp info response to set vsvr interface name to NULL
> >	string so that CLI arp show cmd (for SSC) properly displays
> >	the arp entry interface name.
> 
> Does this code ever get called for vsvr interfaces?  It would seem
> not. nfx-tree/code/ssc-ifconfig/ssc-ifc-linux.c
> 
>      looks good
> 
> RF: No, its specifically for SSC in cluster context.
> 
> nfx-tree/code/ssc-ifconfig/ssc-ifc-openbsd.c
> 
>      while you're here, get rid of the idiotic ifdef on line 476 and
>      related else
> 
> RF: OK
> 
> > Change 29641 by rendellf@rendellf-test on 2008/06/11 17:47:46
> > *pending*
> >
> >	TED22577: Cougar : Invalid entries in "system show users"
> >	command
> >
> >	Changes to validate logged-in user info entries before
> >	displaying them.
> 
> Be more specific - mention function added for this purpose, etc:
> 
> added function foo-bar to validate user info entries before printing
> them.  does nothing on BSD.
> 
> something like that.  thanks.
> nfx-tree/code/ssc-nfxsh/cmd_system-linux.c
> 
>      whatever
> 
> RF: OK
> 
> nfx-tree/code/ssc-nfxsh/cmd_system-openbsd.c
> 
>      duh, ok
> 
> nfx-tree/code/ssc-nfxsh/cmd_system.c
> 
>      line 2234, 6,7 trailing space, ew
> 
> RF: OK
> 
> nfx-tree/code/ssc-nfxsh/nfxsh.h
> 
>      looks good
> 
> > Change 29657 by rendellf@rendellf-test on 2008/06/12 17:35:11
> > *pending*
> >
> >	TED23928: autosupport schedule options should be
> >	independently set
> >
> >	Changed to retain existing schedule options when not
> >	specified in command. Update help for autosupport schedule
> >	command.
> 
> nfx-tree/code/ssc-nfxsh/cmd_autosupport.c
> 
>      line 1388, 1390, 91 trailing space
> 
>      line 1380, 81, 1389, 1396, 1411, 12, use sizeof the actual
> object, not the type
> 
> RF: OK
