AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E09624B56@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 16 Jun 2008 13:15:00 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review - change 29696, 29698, 29699
Message-ID: <20080616131500.6459a0fe@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09624B56@onstor-exch02.onstor.net>
References: <20080616111011.47e0ccfb@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E09624B56@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 16 Jun 2008 12:01:01 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> See RF: comments below.
> 
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Monday, June 16, 2008 11:10 AM
> To: Rendell Fong
> Subject: Re: please review - change 29696, 29698, 29699
> 
> On Mon, 16 Jun 2008 10:09:47 -0700 "Rendell Fong"
> <rendell.fong@onstor.com> wrote:
> 
> > Change: 29696
> > 
> > Client: rendellf-test
> > 
> > User:   rendellf
> > 
> > Description:
> >     TED22268: problem with nfx shell parser that '[options' never
> > shows a ']'
> > 
> >     Suppress brackets from help parameter name tokens from being
> > displayed
> >     since they are only needed for internal nfx shell parsing.
> > Display <cr>
> >     as a valid option when help for an optional parameter is
> > encountered.
> > 
> > Files:
> >     //depot/dev/nfx-tree/code/ssc-nfxsh/vtysh.c # edit
> 
> 
> 
> nfx-tree/code/ssc-nfxsh/vtysh.c
> 
>      since i have no idea what's going on here, i'm just going to
>      nitpick some style. even though you did fix a lot of broken
>      style already.
> 
>      line 470, 471, 499, 500 super ew.  functions with a space between
>      the name and paren.  they're all over the place in this file.
>      eyuck.
> 
>      line 501 spaces around operators like '+'
> 
> 
> RF: OK  -  FYI, This code is similar the readline functionality in
> bash shell which handles command line completion if there is a unique
> match or displaying all possible matches in theory.  For example,
> when "?" is typed on the command line this code is invoked and
> generates output as follows:
> 
> eng59 diag> stats txrx nfs ?
>   [OPTS  [-s VIRTUALSERVER] [-r]
> 
> Note that "[OPTIONS" is displayed which is supposed to be the
> parameter name and optional in this case.  With this fix, it now
> shows up as follows:
> 
> g7r6 diag> stats txrx nfs ?
>   OPTS  [-s VIRTUALSERVER]|[-r]
>   <cr>
> 
> The "[" in the parameter name is suppressed and <cr> is displayed to
> indicate that no other parameters are required for the CLI command.

cool

> > Change: 29698
> > 
> > Client: rendellf-test
> > 
> > User:   rendellf
> > 
> > Description:
> >     TED22531,TED22532: CLI help description not available for
> > "autosupport
> >     emrs send disable" and "autosupport state disable" commands
> > 
> >     Changed autosupport command definitions to map missing help
> > strings to
> >     each of the command arguments for the nfx shell parser.  Also
> > updated
> >     missing help for "autosupport emrs proxy enable" command.
> > 
> > Files:
> >     //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_autosupport.c   # edit
> 
> ok
> 
> 
> > Change: 29699
> > 
> > Client: rendellf-test
> > 
> > User:   rendellf
> > 
> > Description:
> >     TED23633: CLI online help for stats command options
> > 
> >     Changed stat command definitions to map missing help strings to
> >     each for the command arguments for the nfx shell parser.
> > 
> > Files:
> >     //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_stats.c # edit
> 
> 
> 
> > Change 29699 by rendellf@rendellf-test on 2008/06/15 10:41:04
> > *pending*
> > 
> > 	TED23633: CLI online help for stats command options
> > 	
> > 	Changed stat command definitions to map missing help strings
> > to each for the command arguments for the nfx shell parser.
> 
> mention elimination of rude exit's from nfxsh upon certain error
> conditions
> 
> RF: OK
> 
> nfx-tree/code/ssc-nfxsh/cmd_stats.c
> 
>      line 1642 nfs_cmd_req_ptr and nfs_cmd_resp_ptr would just seem
>      to be a waste of air.  just use the objects unless there's some
>      reason I can't see to have these extra pointers laying about.
> 
>      line 1657 ugly whitespace
> 
>      line 1663 change the sizeof's to use the object not the type
> 
>      line 2397 same as before with nfs_cmd_req_ptr and
>      cifs_count_resp_ptr and also the sizeof's
> 
>      line 2561 again with the pointless pointers, although bizarrely
>      they got the sizeof's right, even though not in a uniform manner.
> 
>      line 2603 might as well fix these bizarre exit's like you did
>      the previous ones.
> 
> RF: OK - got rid of the clutter.

excellent
