AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0A82D3C9@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 17 Jun 2008 18:00:14 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Ed Kwan" <ed.kwan@onstor.com>
Subject: Re: Please review code change for TED 24298
Message-ID: <20080617180014.0774c366@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0A82D3C9@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0A82D301@onstor-exch02.onstor.net>
	<20080617161822.6f2835b3@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0A82D3C9@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

OK.


On Tue, 17 Jun 2008 17:49:34 -0700 "Ed Kwan" <ed.kwan@onstor.com> wrote:

> See responses in-line below.
> 
> > -----Original Message-----
> > From: Andy Sharp
> > Sent: Tuesday, June 17, 2008 4:18 PM
> > To: Ed Kwan
> > Subject: Re: Please review code change for TED 24298
> > 
> > > Change 29731 by edk@edk-dev on 2008/06/17 15:31:45 *pending*
> > >
> > > 	Changes for TED 24298.  Modified the default url path to
> > 
> > Please mention what bug 24298 is.
> 
> Done.
> 
> > > reflect recent directory changes on our ftp server.
> > > 	Reviewed by AndyS.
> > 
> > nfx-tree/Tools/cw_install.in
> > 
> > 
> >      line 681, remove the case for CG since this won't be used
> >      on cougar.
> 
> I think we should have a different defect to remove the Cougar code in
> the install script.  In addition to removing the case for CG at line
> 681 and 754, we print an error message and exit if $hwtype is "CG"
> after line 664:
> 
>     664 hwtype=`hw_initials`
> 
> 
> >      any changes for the debug URL on line 686?
> 
> No.
> 
> > 
> > 
> > 
> > 
> > On Tue, 17 Jun 2008 15:36:32 -0700 "Ed Kwan" <ed.kwan@onstor.com>
> wrote:
> > 
> > > Hi Andy,
> > >
> > > The change number is 29731.
> > > With the change, the new URL has the correct directory component,
> > > highlighted in red below:
> > >
> > > 		Please enter the ftp or http URL of the
> > > distribution:
> > >
> > >
> [ftp://support.onstor.com/outbound/software/EverON/3.2.0/3.2.0.6/22xx/Ev
> > > erON-3.2.0.6BC.tar.gz]
> > >
> > > Thanks,
> > > Ed
> > >
> > > [edk@edk-linux Tools]$ p4 diff
> > > ==== //depot/dev/nfx-tree/Tools/cw_install.in#10 -
> > > /homes/edk/p4/dev/nfx-tree/Tools/cw_install.in ====
> > > 24a25,26
> > > > N_VERS_DIR=`expr $N_VERS : '\([0-9]*\.[0-9]*\.[0-9]*\)'`
> > > >
> > > 673c675
> > > <
> > > ftp_url=$DEF_FTP_URL/${N_VERS}/22xx/EverON-${N_VERS}BC.tar.gz
> > > ---
> > > >
> > >
> ftp_url=$DEF_FTP_URL/${N_VERS_DIR}/${N_VERS}/22xx/EverON-${N_VERS}BC.tar
> > > .gz
> > > 676c678
> > > <
> > > ftp_url=$DEF_FTP_URL/${N_VERS}/22xx/EverON-${N_VERS}BL.tar.gz
> > > ---
> > > >
> > >
> ftp_url=$DEF_FTP_URL/${N_VERS_DIR}/${N_VERS}/22xx/EverON-${N_VERS}BL.tar
> > > .gz
> > > 678c680
> > > <
> > > ftp_url=$DEF_FTP_URL/${N_VERS}/44xx/EverON-${N_VERS}.tar.gz
> > > ---
> > > >
> > >
> ftp_url=$DEF_FTP_URL/${N_VERS_DIR}/${N_VERS}/44xx/EverON-${N_VERS}.tar.g
> > > z
> > > 680c682
> > > <
> > > ftp_url=$DEF_FTP_URL/${N_VERS}/69xx/EverON-${N_VERS}CG.tar.gz
> > > ---
> > > >
> > >
> ftp_url=$DEF_FTP_URL/${N_VERS_DIR}/${N_VERS}/69xx/EverON-${N_VERS}CG.tar
> > > .gz
