AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080624130707.318fc26d@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C96D6@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 24 Jun 2008 13:08:53 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review 29806
Message-ID: <20080624130853.4a54680b@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C96D6@onstor-exch02.onstor.net>
References: <20080623213305.284c8ce0@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C96D6@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

The one on k2 in that directory is the one cron runs, so it shouldn't be
used as a place to check out and change that script.  I just made
changes to it to get it working, I didn't check it out or anything.
They aren't part of what I'm doing in my workspace, that is basically a
complete re-write.

On Tue, 24 Jun 2008 12:01:27 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Wait, how did I wipe out your changes? Were there 2 client specs using
> this same workspace? I did it on k2 because I wanted to receive the
> email notices that were being sent to ken's account.
> 
> Hmm, let's see if we can recover your changes. If the file was
> writable, p4 should have opened the file and preserved your edits. 
> 
> I did check for opened nfxbuild.sh files and you have a version
> checked out in ripper and I have nfxbuild.sh checked out in
> build-k2-depot. Are your changes in your ripper workspace?
> 
> Larry
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Monday, June 23, 2008 9:33 PM
> To: Larry Scheer
> Subject: Re: please review 29806
> 
> dude, you checked this out on k2?  why?  it looks like you wiped out
> my changes that were making this script actually run.
> 
> On Mon, 23 Jun 2008 12:24:27 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > [build@k2 buildver]$ p4 describe 29806
> > Change 29806 by larrys@build-k2-depot on 2008/06/23 12:21:52
> > *pending*
> > 
> >         Update list of people who recieve email notices.
> >         Reviewed by: andys
> > 
> > Affected files ...
> > 
> > ... //depot/cm/build_scripts/buildver/nfxbuild.sh#46 edit
> > 
> > 
> > [build@k2 buildver]$ p4 diff -du nfxbuild.sh 
> > ==== //depot/cm/build_scripts/buildver/nfxbuild.sh#46 -
> > /perforce/trees/cm/build_scripts/buildver/nfxbuild.sh ====
> > @@ -735,7 +735,7 @@
> >  
> >                 # Mail dl-software et al with successfull nightly
> > builds if [ ${NIGHTLY} == "true" ]; then
> > -                       mail
> >
> sandrine.boulanger@onstor.com,ken.renshaw@onstor.com,tim.gardner@onstor.
> > com,dl-software@onstor.com -s \
> > +                       mail
> >
> sandrine.boulanger@onstor.com,larry.scheer@onstor.com,andy.sharp@onstor.
> > com,dl-software@onstor.com -s \
> >                         "Nightly build of all ${BRANCH} branch
> > targets PASSED last night <EOM>"
> >                 fi
> >         fi
> > @@ -752,7 +752,7 @@
> >         echo "" >> ${BUILDLOGS}/err-context.out
> >         echo "Please check compilation logs at http://liszt for
> > today for the ${BRANCH} branch" >> ${BUILDLOGS}/err-context.out
> >         cat ${BUILDLOGS}/err-context.out | mail -s "Compilation
> > failure in ${BRANCH} branch" \
> > -
> >
> sandrine.boulanger@onstor.com,paul.hammer@onstor.com,ken.renshaw@onstor.
> > com,tim.gardner@onstor.com,dl-software@onstor.com
> > +
> >
> sandrine.boulanger@onstor.com,paul.hammer@onstor.com,larry.scheer@onstor
> > .com,andy.sharp@onstor.com,dl-software@onstor.com
> >  
> >         # @@@ section to scan Perforce changelists for offending
> > checkin causing build break goes in here -klr
> >         #
> > @@ -1112,7 +1112,7 @@
> >  
> >  rm -f /home/upgrade/NIGHTLY/*
> >  
> > -cat ${BUILDLOGS}/auditlog | mail -s "Auditlog for build of
> > ${BRANCH} at `date` completed" ken.renshaw@onstor.com
> > +cat ${BUILDLOGS}/auditlog | mail -s "Auditlog for build of
> > ${BRANCH} at `date` completed" larry.scheer@onstor.com
> >  
> > 
