AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080624151940.671d94ab@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C96DC@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Tue, 24 Jun 2008 15:21:25 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review 29806
Message-ID: <20080624152125.6bf9631b@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C96DC@onstor-exch02.onstor.net>
References: <20080624130853.4a54680b@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C96DC@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Uh, excuse me, but I think I called 'should' first, so you don't get to
use it.

Here you're talking about if this directory/workspace was supposed to
be used, but it's not.  You "should" have made the changes in your own
workspace and then sync'd this directory.

And in general you don't need my review for something like this, you
can just change it, unless it was forcing you.  Changes to the logic,
well, maybe the same, but I would normally ask someone to review those
just to protect myself from myself.

On Tue, 24 Jun 2008 13:22:14 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> But still, if you made changes a p4 edit should have preserved your
> changes unless p4 sync was done that reverted your changes. If that is
> what happened you should have done a p4 edit before you made any
> changes to that file. There are other files in that workspace that
> need refreshed from time to time.
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Tuesday, June 24, 2008 1:09 PM
> To: Larry Scheer
> Subject: Re: please review 29806
> 
> The one on k2 in that directory is the one cron runs, so it shouldn't
> be used as a place to check out and change that script.  I just made
> changes to it to get it working, I didn't check it out or anything.
> They aren't part of what I'm doing in my workspace, that is basically
> a complete re-write.
> 
> On Tue, 24 Jun 2008 12:01:27 -0700 "Larry Scheer"
> <larry.scheer@onstor.com> wrote:
> 
> > Wait, how did I wipe out your changes? Were there 2 client specs
> > using this same workspace? I did it on k2 because I wanted to
> > receive the email notices that were being sent to ken's account.
> > 
> > Hmm, let's see if we can recover your changes. If the file was
> > writable, p4 should have opened the file and preserved your edits. 
> > 
> > I did check for opened nfxbuild.sh files and you have a version
> > checked out in ripper and I have nfxbuild.sh checked out in
> > build-k2-depot. Are your changes in your ripper workspace?
> > 
> > Larry
> > 
> > -----Original Message-----
> > From: Andy Sharp 
> > Sent: Monday, June 23, 2008 9:33 PM
> > To: Larry Scheer
> > Subject: Re: please review 29806
> > 
> > dude, you checked this out on k2?  why?  it looks like you wiped out
> > my changes that were making this script actually run.
> > 
> > On Mon, 23 Jun 2008 12:24:27 -0700 "Larry Scheer"
> > <larry.scheer@onstor.com> wrote:
> > 
> > > [build@k2 buildver]$ p4 describe 29806
> > > Change 29806 by larrys@build-k2-depot on 2008/06/23 12:21:52
> > > *pending*
> > > 
> > >         Update list of people who recieve email notices.
> > >         Reviewed by: andys
> > > 
> > > Affected files ...
> > > 
> > > ... //depot/cm/build_scripts/buildver/nfxbuild.sh#46 edit
> > > 
> > > 
> > > [build@k2 buildver]$ p4 diff -du nfxbuild.sh 
> > > ==== //depot/cm/build_scripts/buildver/nfxbuild.sh#46 -
> > > /perforce/trees/cm/build_scripts/buildver/nfxbuild.sh ====
> > > @@ -735,7 +735,7 @@
> > >  
> > >                 # Mail dl-software et al with successfull nightly
> > > builds if [ ${NIGHTLY} == "true" ]; then
> > > -                       mail
> > >
> >
> sandrine.boulanger@onstor.com,ken.renshaw@onstor.com,tim.gardner@onstor.
> > > com,dl-software@onstor.com -s \
> > > +                       mail
> > >
> >
> sandrine.boulanger@onstor.com,larry.scheer@onstor.com,andy.sharp@onstor.
> > > com,dl-software@onstor.com -s \
> > >                         "Nightly build of all ${BRANCH} branch
> > > targets PASSED last night <EOM>"
> > >                 fi
> > >         fi
> > > @@ -752,7 +752,7 @@
> > >         echo "" >> ${BUILDLOGS}/err-context.out
> > >         echo "Please check compilation logs at http://liszt for
> > > today for the ${BRANCH} branch" >> ${BUILDLOGS}/err-context.out
> > >         cat ${BUILDLOGS}/err-context.out | mail -s "Compilation
> > > failure in ${BRANCH} branch" \
> > > -
> > >
> >
> sandrine.boulanger@onstor.com,paul.hammer@onstor.com,ken.renshaw@onstor.
> > > com,tim.gardner@onstor.com,dl-software@onstor.com
> > > +
> > >
> >
> sandrine.boulanger@onstor.com,paul.hammer@onstor.com,larry.scheer@onstor
> > > .com,andy.sharp@onstor.com,dl-software@onstor.com
> > >  
> > >         # @@@ section to scan Perforce changelists for offending
> > > checkin causing build break goes in here -klr
> > >         #
> > > @@ -1112,7 +1112,7 @@
> > >  
> > >  rm -f /home/upgrade/NIGHTLY/*
> > >  
> > > -cat ${BUILDLOGS}/auditlog | mail -s "Auditlog for build of
> > > ${BRANCH} at `date` completed" ken.renshaw@onstor.com
> > > +cat ${BUILDLOGS}/auditlog | mail -s "Auditlog for build of
> > > ${BRANCH} at `date` completed" larry.scheer@onstor.com
> > >  
> > > 
