AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080625165016.438b8092@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<ed.kwan@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0AA0A8C6@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 25 Jun 2008 16:51:38 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Ed Kwan" <ed.kwan@onstor.com>
Subject: Re: Please review code change for several cli defects
Message-ID: <20080625165138.65a97d03@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0AA0A8C6@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0AA0A8C6@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

1. In general, that's fine; if it involves design or approach
modifications, a wider audience might be prudent.  Not necessarily by
review process but something less formal especially if it's small.

2.


nfx-tree/code/ssc-nfxsh/cmd_audit.c

     looks good

nfx-tree/code/ssc-nfxsh/cmd_domain.c

     looks good

nfx-tree/code/ssc-nfxsh/nfxsh.h

     nak.  don't use inlines except for speed, which is not required
     here.  put in command.c or vtysh.c or something.  in nfxsh
     code i notice that it's common to put a generic routine in some
     semi-random file and use it in many others by just throwing an
     extern statement in the other files.  that's fine with me too.





On Tue, 24 Jun 2008 19:08:10 -0700 "Ed Kwan" <ed.kwan@onstor.com> wrote:

> Hi Andy,
> 
> 1.	I'll assign a bunch of CLI defects to the new Escalation
> Engineer Ram.  I would like your permission to let Danqing and me to
> review his code changes.
> 2.	Please review my code change for the following defects:
> 	
> 	TED00022498 "audit set filesize VOLNAME FILESIZE" - When any
> junk values passed for 'FILESIZE", its not giving any errors.  
> 	TED00022499 "auth getNfsTokenPrivs UID GID [GID]" - not giving
> proper error message when any junk values passed with it.  
> 	TED00022500 "auth nfsid2sid UID [ID]" - not giving proper
> error message when any junk values passed with this command.  
> 	TED00022501 "auth nfs2cifstoken UID GID [GID ]"- not giving
> proper error message when any junk values passed with this command. 
> 
> 	We expect the input argument to be a number, but we run atoi()
> without first checking the string.  atoi() returns 0 on error, which
> is still a valid value.  To fix this, I'm moving the all_digits()
> routine from cmd_domain.c to nfxsh.h, so we can use it in many places
> to check the input string.
> 
> Thanks,Ed
> 	
> 	[edk@edk-linux nfx-tree]$ p4 describe 29836
> 	Change 29836 by edk@edk-dev on 2008/06/24 19:03:24 *pending*
> 
> 	        Changes for the following 4 defects:
> 	          TED00022498 "audit set filesize VOLNAME FILESIZE" -
> When any junk
> 	          values passed for 'FILESIZE", its not giving any
> errors.
> 	          TED00022499 "auth getNfsTokenPrivs UID GID [GID]" -
> not giving proper
> 	          error message when any junk values passed with it.
> 	          TED00022500 "auth nfsid2sid UID [ID]" - not giving
> proper error
> 	          message when any junk values passed with this
> command. TED00022501 "auth nfs2cifstoken UID GID [GID ]"- not
> giving proper
> 	          error message when any junk values passed with this
> command.
> 	        Move the all_digits() routine from cmd_domain.c to
> nfxsh.h, and
> 	        use it to check the input string in various places.
> 	        Reviewed by AndyS.
> 
> 	Affected files ...
> 
> 	... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_audit.c#14 edit
> 	... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_domain.c#16 edit
> 	... //depot/dev/nfx-tree/code/ssc-nfxsh/nfxsh.h#11 edit
