AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080716000252.5930d6f1@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<jobi.ariyamannil@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#mh/Mailbox/perfarce	0	WEBMAILaxEqh2MJBeHg0000330a@mail.onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 16 Jul 2008 00:03:58 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Jobi Ariyamannil <jobi.ariyamannil@onstor.com>
Subject: Re: PERFORCE change 30046 for review
Message-ID: <20080716000358.7994740e@ripper.onstor.net>
In-Reply-To: <WEBMAILaxEqh2MJBeHg0000330a@mail.onstor.com>
References: <WEBMAILaxEqh2MJBeHg0000330a@mail.onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On 15 Jul 2008 23:25:01 -0700 Jobi Ariyamannil
<jobi.ariyamannil@onstor.com> wrote:

> Change 30046 by jobia@jobi:jobi2 on 2008/07/15 23:22:01
> 
> 	   Signal the background cleaner threads also during
> filesystem sync. Write out the superblock when fscmd sync is issued. 
> 	   Take the access lock when fscmd freeze is issued. 
> 	
> 	   Reviewed by AmitB.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-fs/fs-admin.c#35 edit
> 
> 
> http://liszt:1818/@md=d&cd=//depot/$c=G35@/30046?ac=10

> Change 30047 by jobia@jobi:jobi2 on 2008/07/15 23:26:44
> 
> 	   Let the commit requests to proceed even if the filesystem
> running low on log resources.
> 	
> 	
> 	   Reviewed by AmitB.
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/sm-fs/fs-nfs.c#53 edit
> ... //depot/dev/nfx-tree/code/sm-fs/requests.tab#12 edit

Jobi,

Aieee!  What are these changes?  There's no bug number.  They're not
cougar?  Then they don't belong in the dev branch and you shouldn't be
working on them for sure.

Yes, we have release branch, but the dev branch is not open yet for
non-cougar checkins.

I thought I made that clear in my email.

If these aren't part of cougar then they have to be reverted until the
dev branch is open for non-cougar, probably early next week.

Thanks,

a
