AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080716105259.1de9b9ab@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<maxim.kozlovsky@onstor.com>,<jonathan.goldick@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E0AF1D956@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 16 Jul 2008 10:53:37 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Maxim Kozlovsky" <maxim.kozlovsky@onstor.com>
Cc: Jonathan Goldick <jonathan.goldick@onstor.com>
Subject: Re: Please review
Message-ID: <20080716105337.11ab6a07@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E0AF1D956@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E0AF1D3C2@onstor-exch02.onstor.net>
	<20080716093056.01e0c3f6@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E0AF1D956@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 16 Jul 2008 09:48:12 -0700 "Maxim Kozlovsky"
<maxim.kozlovsky@onstor.com> wrote:

> 
> 
> >-----Original Message-----
> >From: Andy Sharp
> >Sent: Wednesday, July 16, 2008 9:31 AM
> >To: Maxim Kozlovsky
> >Subject: Re: Please review
> >
> >On Tue, 15 Jul 2008 10:14:15 -0700 "Maxim Kozlovsky"
> ><maxim.kozlovsky@onstor.com> wrote:
> >
> >> Change 30017 by maximk@maximk-13 on 2008/07/15 10:13:54 *pending*
> >>
> >>         24694   time zone not cleared after 'system config reset'
> >>
> >>            Remove /etc/localtime and /etc/timezone files on config
> >> reset.
> >>            Reviewed by andys.
> >>
> >> Affected files ...
> >>
> >> ... //depot/dev/nfx-tree/code/ssc-genlib/genlib-linux.c#8 edit
> >> ... //depot/dev/nfx-tree/code/ssc-genlib/genlib-openbsd.c#9 edit
> >> ... //depot/dev/nfx-tree/code/ssc-genlib/genlib.h#7 edit
> >> ... //depot/dev/nfx-tree/code/ssc-nfxsh/cmd_flash.c#18 edit
> >> ... //depot/dev/nfx-tree/code/ssc-tests/utilstest.c#4 edit
> >
> >OK, Sripal says this approach has a couple of problems including
> >during upgrade and as well as one or two others.  This is a P3 and
> >not worth your time, I'm going to send it back to triage for
> >reclassification to P3/Kegg.  That's what I was going to do anyway,
> >but you're too fast.
> 
> [MK] Ok that's what I'll tell you next time you'll send me some code
> for review. It is has one or two problems, but I am not going to tell
> you which. 

It has nothing to do with the review and everything to do with the bug
itself and whether we should even be doing this, especially now.  I'm
just doing my job, don't try so hard to take it personally.

> >
> >I think the best use of your time might be to engineer a viable fix
> >for 24067 because resetting the FP causes kernel oops in some
> >workflows.  I talked to Jon some about this last night. One thing is
> >I have a changelist which does overhaul the reboot process somewhat,
> >but doesn't go far enough (according to Jon) as it only quiesces the
> >TXRX ports and possibly not the FP.  Maybe a combination of that
> >changelist and something you come up with for the FP (add an RPC
> >that does a halt on all cores?) would do the trick.
> >
> [MK] You do that.

What does that mean?

> >Cheers,
> >
> >a
