AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080716181938.5930db71@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<rendell.fong@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	44183	BB375AF679D4A34E9CA8DFA650E2B04E09624BA8@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 16 Jul 2008 18:19:44 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Rendell Fong" <rendell.fong@onstor.com>
Subject: Re: please review 30063
Message-ID: <20080716181944.7733b246@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E09624BA8@onstor-exch02.onstor.net>
References: <BB375AF679D4A34E9CA8DFA650E2B04E09624BA8@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

I have updated the comments.

The PGID is the PID that is passed in.  Fixed the comments to reflect.

Not causing any system get all problems unless you count the one this
change fixes.

I threw in a couple of things that might suppress some of the obnoxious
messages, so please re-review.

Thanks,

a

On Wed, 16 Jul 2008 16:38:32 -0700 "Rendell Fong"
<rendell.fong@onstor.com> wrote:

> If you haven't checked it in yet, please update the comments. (line
> 270) SIGKILL -> SIGTERM
> 
> Also, the comments mention ppid but pgid is referenced in the "ps ax"
> command.  Is there a difference?  Could this be causing support.sh of
> a different parent to be killed?  Just wondering if this is possibly
> causing the "system get all" problem.
> 
> 
> -----Original Message-----
> From: Rendell Fong 
> Sent: Wednesday, July 16, 2008 4:25 PM
> To: Andy Sharp
> Subject: RE: please review 30063
> 
> ok
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, July 16, 2008 4:18 PM
> To: Rendell Fong
> Subject: please review 30063
> 
> Change 30063 by andys@ripper on 2008/07/16 16:15:42 *pending*
> 
>         TED00024751 - System get all processes not reaped after timing
> out
>         
>         The process reaping code was just a little too murderous for
>         it's own good, actually allowing evildoers to evade the axe.
>         
>         Change "kill -9" to "kill -TERM" (the default) and no one
> escapes.
>         
>         reviewed by
> 
> Affected files ...
> 
> ... //depot/dev/nfx-tree/code/ssc-support/support.sh#34 edit
> 
