AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080721092729.4d3a2f3f@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<sripal.surendiran@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	48845AC7.4070407@onstor.com
X-Sylpheed-End-Special-Headers: 1
Date: Mon, 21 Jul 2008 09:27:37 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: Sripal <sripal.surendiran@onstor.com>
Subject: Re: Review : Fix for TED00024695
Message-ID: <20080721092737.64697a67@ripper.onstor.net>
In-Reply-To: <48845AC7.4070407@onstor.com>
References: <487F03D3.7050305@onstor.com>
	<20080718162522.302df85f@ripper.onstor.net>
	<48845AC7.4070407@onstor.com>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Good to go.  Sorry the review took so long.

Cheers,

a

On Mon, 21 Jul 2008 15:15:43 +0530 Sripal
<sripal.surendiran@onstor.com> wrote:

> Thanks Andy,
> 
> See my inline comments.
> 
> 
> Andrew Sharp wrote:
> >> Change 30016 by sripal@sripal-rdev on 2008/07/15 04:47:29 *pending*
> >>
> >> 	TED00024695 - NCM FTI - no easy way to know which node of a
> >> Cougar-in-a-box you are about to configure
> >> 	Now dhclient-script will check, if the system MAC address
> >> belong to top slot(chassis MAC + 0x00) or bottom slot(chassis MAC +
> >> 0x80) and change the default ip address accordingly.
> >> 	Here is the default ip address for top and bottom slots
> >> 	
> >> 	1. Top slot
> >> 	sc0 - 172.18.250.250  --> MAC address + 0x0
> >> 	sc1 - 172.19.250.250  --> MAC address + 0x1
> >> 	
> >> 	2. Bottom slot
> >> 	sc0 - 172.18.250.251  -->MAC address + 0x80
> >> 	sc1 - 172.19.250.251  -->MAC address + 0x81
> >>
> >>     
> >
> > linux/rootfs/sbin/dhclient-script
> >
> >      line 272, do like so: ifconfig $interface | grep 'HWaddr' | awk
> >      '{print $5}'
> >   
> Sripal> Modified and tested
> >      because there's no guarantee the interface is up when this is
> > run.
> >
> >      line 275 in general, i'm not clear on why the whole 'x' thing
> >      if double quotes are used for all variable substitutions...but
> >      whatever.
> >
> >
> >
> > Sripal> Done.(Tested)
> >
> >
> >
> > On Thu, 17 Jul 2008 14:03:23 +0530 Sripal
> > <sripal.surendiran@onstor.com> wrote:
> >
> >   
> >> Andy,
> >>
> >> I have fixed and tested the bug. Request you to review the changes.
> >>
> >> Change id : 30016
> >>
> >> [sripal@linux-compile ~]#p4 describe 30016
> >> Change 30016 by sripal@sripal-rdev on 2008/07/15 04:47:29 *pending*
> >>
> >>         TED00024695 - NCM FTI - no easy way to know which node of
> >> a Cougar-in-a-box you are
> >>         about to configure
> >>         Now dhclient-script will check, if the system MAC address
> >> belong to top
> >>         slot(chassis MAC + 0x00) or bottom slot(chassis MAC + 0x80)
> >> and change
> >>         the default ip address accordingly.
> >>         Here is the default ip address for top and bottom slots
> >>
> >>         1. Top slot
> >>         sc0 - 172.18.250.250  --> MAC address + 0x0
> >>         sc1 - 172.19.250.250  --> MAC address + 0x1
> >>
> >>         2. Bottom slot
> >>         sc0 - 172.18.250.251  -->MAC address + 0x80
> >>         sc1 - 172.19.250.251  -->MAC address + 0x81
> >>
> >> Affected files ...
> >>
> >> ... //depot/dev/linux/rootfs/sbin/dhclient-script#2 edit
> >>
> >> Thanks,
> >> Sripal.
> >>
> >>     
> 
