AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20080723123108.0be84a8b@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E056C9740@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 23 Jul 2008 12:31:20 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: please review 30139
Message-ID: <20080723123120.4b041242@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E056C9740@onstor-exch02.onstor.net>
References: <20080723113144.5bc95d41@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E056C9740@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 23 Jul 2008 12:15:34 -0700 "Larry Scheer"
<larry.scheer@onstor.com> wrote:

> Did you want to use uint32_t and uint8_t versus u32 and u8? I see it
> used to be uint32_t. I see the definition of uint32_t will change
> based on the definition of a LONG -- just checking. 
> 
> If you do want u32 and u8 it is ok to check in.

I do, 'cuz they can't change, or the protocol will break.

> Why did Jonathan want the NFX_ASSERT_STATIC in the kernel code? That
> just seems wrong to me. It also makes building the kernel a bit
> convoluted.

I can only guess that he brain-farted.

> Larry
> 
> -----Original Message-----
> From: Andy Sharp 
> Sent: Wednesday, July 23, 2008 11:32 AM
> To: Larry Scheer
> Subject: please review 30139
> 
> This is to fixbuild breakage introduced by Jon's checkin for adding
> model support.  Tested as far as compiling goes.
> 
> Change 30139 by andys@ripper on 2008/07/23 11:20:32 *pending*
> 
> 	Fix Linux kernel build breakage introduced in changelist
> 30128. 
> 	reviewed by
> 
> Affected files ...
> 
> ...
> //depot/dev/linux/kernel/linux-mips-2.6/drivers/ssc-mgmt-bus/mgmt-bus.h#
> 7 edit
