AF:
NF:0
PS:10
SRH:1
SFN:
DSR:
MID:<20070321112356.637c5262@ripper.onstor.net>
CFG:
PT:0
S:andy.sharp@onstor.com
RQ:
SSV:onstor-exch02.onstor.net
NSV:
SSH:
R:<tim.gardner@onstor.com>,<larry.scheer@onstor.com>
MAID:1
X-Sylpheed-Privacy-System:
X-Sylpheed-Sign:0
SCF:#mh/Mailbox/sent
RMID:#imap/andys@onstor.net@onstor-exch02.onstor.net/INBOX	0	BB375AF679D4A34E9CA8DFA650E2B04E02F12266@onstor-exch02.onstor.net
X-Sylpheed-End-Special-Headers: 1
Date: Wed, 21 Mar 2007 11:24:24 -0700
From: Andrew Sharp <andy.sharp@onstor.com>
To: "Tim Gardner" <tim.gardner@onstor.com>
Cc: "Larry Scheer" <larry.scheer@onstor.com>
Subject: Re: PERFORCE change 23200 for review
Message-ID: <20070321112424.5b54ad0e@ripper.onstor.net>
In-Reply-To: <BB375AF679D4A34E9CA8DFA650E2B04E02F12266@onstor-exch02.onstor.net>
References: <WEBMAILvZ9Spc6foT9s00000864@mail.onstor.com>
	<20070321101734.68be0eaf@ripper.onstor.net>
	<BB375AF679D4A34E9CA8DFA650E2B04E02F12266@onstor-exch02.onstor.net>
Organization: Onstor
X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.8.20; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 21 Mar 2007 11:17:10 -0700 "Tim Gardner"
<tim.gardner@onstor.com> wrote:

> Are you volunteering?

Always.  Also, I think Jonathon would be happy to volunteer. ~:^)

> I believe that in the past we did not require code reviews of
> Makefiles. This is why perforce is not checking for a reviewed by
> field. Larry and I discussed the changes he was planning to make so I
> am comfortable with his checkin. I am also fine if you would like to
> review his work before he checks something in.

No time like the present to fix what's broken.  A review of makefile
changes should be just as mandatory.  Ex: I made a makefile change that
didn't get reviewed.  Broken everything all to snot.

Cheers,

a
